Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve expansion of reference records, parent records and sub-form records #136

Open
nickdickinson opened this issue Oct 16, 2024 · 1 comment

Comments

@nickdickinson
Copy link
Collaborator

nickdickinson commented Oct 16, 2024

For the convenience of the user and to reduce the load on the server, provide an explicit grammar to allow the user to expand reference fields, parent records and sub-form records. The current automatic expansion would be used to implement these but reduce the load on the server by only showing what users explicitly want to see.

There are two potential approaches that can be implemented.

Approach 1: ActivityInfo label/code based selection of columns.

This would be easiest for ActivityInfo users who dabble in scripts. It would be a wrapper for getRecords() and select() and rename() to allow immediately selecting variables in activityInfo style with the label and/or the code or id of each column and choose the resulting names.

In pseudo R to get all inhabitants of households with a reference to a Person form for all person fields:

df = selectFormVariables(
     inhabitantFormId, 
     vars = c(
          'Household ID' =  '@parent.[ID]', 
          'Inhabitant name' = '[Inhabitant].[Full name]',
          'Mother name' = '[Inhabitant].[Mother].[Full name]', 
          'Father name' = '[Inhabitant].[Father].[Full name]', 
          'HH head gender' = '@parent.[Head of household].[Gender]')
          'HH head age' = '@parent.[Head of household].[Age]')
)

Approach 2: Tidyverse verbs

This is the best from an R developer / data science perspective. We would implement unnest verbs. These verbs include unnest_wider() for reference fields and parent records and unnest_longer() for sub-form records and potentially unnest_auto() to automatically choose the most appropriate and potentially hoist() to be more specific in selection. The example below shows how one can use the tidy select functions to powerfully select exactly which variables are needed.

In pseudo R to get all inhabitants of households with a reference to a Person form for all person fields:

getRecords(inhabitantFormId) %>%
     unnest_wider(Inhabitant) %>%
     unnest_wider(Mother, names_sep = ' ') %>%
     unnest_wider(Father, names_sep = ' ') %>%
     unnest_wider(`@parent`, ' ') %>%
     rename(`Head of household` = `@parent Head of household`) %>% 
     unnest_wider(`Head of household`, names_sep = '') %>%
     select(`Full name`, `Mother Full name`, `Father Full name`, starts_with('@parent') & contains('ID'), contains('Head') & (contains('Gender') || contains('Age'))

Principles:

  • It would unnest columns that are unexpanded reference, parent or subform fields.
  • It would do nothing if these are already expanded.
  • Allow arbitrary expansion, even if cycles are in place.
  • One could still use getRecords(inhabitantFormId, allColumnsStyle(maxDepth = n)) to be able to use the ActivityInfo label/code to select columns at depth n but we would limit this practice due to the way that the number of columns can blow up and because we don't expand forms that have already been visited.

Combined

Both approaches are compatible and could be chained. It is mainly about exposing the most useful API.

@nickdickinson
Copy link
Collaborator Author

@jamiewhths Forgot to mention this. I worked out a couple of options for an implementation of what we discussed.

Option 1 would be easy to implement BUT only if we stick to our existing varNames() implementation which then limits the expansion in cycles. For example, [supervisor].[employee].[supervisor] would not work because we do not revisit forms during the variable expansion. If we parse the variable names and perhaps do a little re-write on varNames() then we could expand arbitrarily into cycles and would require more effort initially to code.

Is there a way for us to do this with the help of the server? For example, send the '[Inhabitant].[Mother].[Full name]' to the server and get back the field id if it is correct? For a whole list of columns?

Option 2 would allow arbitrary expansion into cycles. A bit more effort as we'll be implementing the dplyr verbs but more standardized from an R / data science perspective.

Want to place this in a 4.39 milestone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant