Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations for zxcvbn feedback #1209

Open
1162706031 opened this issue Oct 9, 2023 · 3 comments
Open

Translations for zxcvbn feedback #1209

1162706031 opened this issue Oct 9, 2023 · 3 comments
Labels
proposal A proposal for a new feature

Comments

@1162706031
Copy link

1162706031 commented Oct 9, 2023

When setting passwords in a non-English environment, feedback warnings and suggestions are provided below, the feedback warnings are still in English, which may not be user-friendly for non-English speaking users.
image

It would be nice to have support for multilingual warnings and suggestions.

@1162706031 1162706031 added the proposal A proposal for a new feature label Oct 9, 2023
@1162706031
Copy link
Author

If possible, I hope you can assign this issue to me. Thank you.

@1162706031
Copy link
Author

Does anyone have any feedback? Thank you very much.

@alexbakker
Copy link
Member

For some languages, zxcvbn4j already bundles translations: https://github.com/nulab/zxcvbn4j#default-language-support. Those should already work in Aegis as well. The list of supported languages is not very long though.

Did you find a clean way to make translation for those strings the responsibility of Aegis? It may be better to contribute translations to zxcvbn4j directly instead of duplicating that work in Aegis.

@alexbakker alexbakker changed the title Add Multilanguage Support for Feedback Warnings and Suggestions Translations for zxcvbn feedback Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature
Projects
None yet
Development

No branches or pull requests

2 participants