Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When "tap to reveal" is selected, obscured entries' dots should be greyed out to reduce clutter #672

Closed
dkogias opened this issue Jan 21, 2021 · 6 comments · Fixed by #1602
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature

Comments

@dkogias
Copy link

dkogias commented Jan 21, 2021

Context: Dozens of accounts in the vault, with many of them different accounts on the same provider/icon.

With "tap to reveal" the obscuring dots visually clutter the list. Greying them out (perhaps to the same extent that non-selected entries are greyed out when "highlight tokens when tapped" greys out non-selected entries) will make the account IDs stand out more, so it's easier to visually locate the right one.

@dkogias dkogias added the proposal A proposal for a new feature label Jan 21, 2021
@alexbakker
Copy link
Member

We're pretty happy with the way things look right now. But feel free to play around with this and let us know if you come up with something you think looks better.

@dkogias
Copy link
Author

dkogias commented Jan 24, 2021

Imagine a long list of entries like this, with many accounts on github (or other providers):
Screenshot_20210124-132505
what I'm visually hunting for is the username, so I'd like that to stand out more, and the repeating 6-dot patterns greyed out instead:
modified

@alexbakker
Copy link
Member

@michaelschattgen Curious to hear your thoughts on this.

@AbramTTP
Copy link

I remember I made a proposal about the dot being too obnoxiously big too.

Perhaps it's just my OCD, because the numbers don't space the same as the dots when revealed.

I personally also find this a good UI idea.

@mannp
Copy link

mannp commented Feb 12, 2021

+1 for me, the dots could be highlighted only when selected, else the primary focus for me is a mass of dots :)

Love the app, but do like the idea of greyed dots while the item is not selected.

@OmlineEditor
Copy link

replace the circles with a minus sign as in the appendix FreeOTP+. the circles are really big and distracting.

unnamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal A proposal for a new feature proposal-accepted An accepted proposal for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants