Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Can't access settings on 1.0 #119

Closed
GNS7 opened this issue Feb 17, 2023 · 25 comments
Closed

[BUG] Can't access settings on 1.0 #119

GNS7 opened this issue Feb 17, 2023 · 25 comments
Labels
bug Something isn't working

Comments

@GNS7
Copy link

GNS7 commented Feb 17, 2023

Describe the bug
Can't access settings (V. 1.0)

To Reproduce
Steps to reproduce the behavior:

  1. Go to settings

Expected behavior
open settings page.

Screenshots
If applicable, add screenshots to help explain your problem.
image

Additional context
Add any other context about the problem here.

@GNS7 GNS7 added the bug Something isn't working label Feb 17, 2023
@GNS7 GNS7 changed the title [BUG] Can't access settings on 1.0 Feb 17, 2023
@beeradmoore beeradmoore changed the title Can't access settings on 1.0 [BUG] Can't access settings on 1.0 Feb 17, 2023
@beeradmoore
Copy link
Owner

Are you using the installer or port table version of DLSS Swapper?

@MelvinSmiley
Copy link

I have the same problem with 1.0, both with portable and installer version. Had this problem also with 0.95, but there I could fix it by starting the program as admin. This workaround no longer works with 1.0 though.

@beeradmoore
Copy link
Owner

For the 1.0 installer version it should generate a log in the %TEMP% directory (open explorer and put that as the path to go to). Log files start with dlss_swapper_ and then I think there is a date after that.

Would you be able to make the issue happen again and then grab the latest error log. Fingers crossed it wrote an error log.

@beeradmoore
Copy link
Owner

There was another issue reported that I can't find at the moment, stated that you couldn't navigate away from the games page if games were loading. But the first pic shows the games are loaded 🥲

@MelvinSmiley
Copy link

MelvinSmiley commented Feb 17, 2023

I had the portable version in C:\Program Files\DLSS Swapper, started Swapper and it wrote this in the log file:
2023-02-17 23:16:58.661 +01:00 [ERR] Storage.cs:189 SaveDLSSRecordsJsonAsync - Access to the path 'C:\Program Files\DLSS Swapper\StoredData\json\dlss_records.json' is denied.
2023-02-17 23:16:58.676 +01:00 [ERR] Storage.cs:138 SaveSettingsJsonAsync - Access to the path 'C:\Program Files\DLSS Swapper\StoredData\json\settings.json' is denied.
2023-02-17 23:17:00.057 +01:00 [ERR] Storage.cs:138 SaveSettingsJsonAsync - Access to the path 'C:\Program Files\DLSS Swapper\StoredData\json\settings.json' is denied.
2023-02-17 23:17:00.090 +01:00 [ERR] Storage.cs:138 SaveSettingsJsonAsync - Access to the path 'C:\Program Files\DLSS Swapper\StoredData\json\settings.json' is denied.

Now I moved it to C:\ to avoid this and I don't get this log entry anymore, just a couple of ubisoft connect error messages. Still can't access settings though, the wheel starts spinning and then nothing happens. Going back to 0.95 version because of this.

@beeradmoore
Copy link
Owner

If the wheel continues to spin it's because it isn't finished loading games which prevents you from navigating away.

The not loading games can be fixed by disabling some of the game platforms, but you can't disable them because you can't access settings 😂

I'll make a change to game loading to allow navigation while it's still loading.

@yaron777
Copy link

I have the same problem, unfortunately nothing is logged in the notepad file.
All games are loaded before going to settings. It shows that the settings button is selected, but the right part of the view doesn't change (stays on the game/library view)
I did not have this in previous versions and am using the installer version of 1.0, although the last version I used was the one via the Windows store.
PrtScr capture

@wenceslaorl
Copy link

Same problem here.

@beeradmoore
Copy link
Owner

I was looking into this one on the weekend. Tried making settings page throw errors but it didn't seem to replicate this issue. Must be elsewhere. Will continue to investigate.

Are people experiencing this issue on Win10 or Win11 or do we have a mixture of both?

When the issue happens does clicking the filter button in the top right bring up the filter menu? Does trying to get to library work?

@wenceslaorl
Copy link

I was looking into this one on the weekend. Tried making settings page throw errors but it didn't seem to replicate this issue. Must be elsewhere. Will continue to investigate.

Are people experiencing this issue on Win10 or Win11 or do we have a mixture of both?

When the issue happens does clicking the filter button in the top right bring up the filter menu? Does trying to get to library work?

Windows 10, installer version.

@lindareicher
Copy link

Same issue here.

Win 11, with both, installer and portabel version.

@beeradmoore
Copy link
Owner

Another question, trying to find what connects you all so I can replicate the issue here.

For installer version did you install to the default location (C:\Program Files\DLSS Swapper) or elsewhere?

For portable version are you running from an extracted location where you have full permissions? (Eg extract into Downloads folder, run from there there, move to desktop, move to documents, etc)

@lindareicher
Copy link

lindareicher commented Feb 20, 2023

"Yes" for both questions. (default location + extracted for portable)

@MelvinSmiley
Copy link

I'm using Windows 10 and I was able to reproduce this error with default "C:\Program Files" or changed install location. Whether it's portable or the installer version also didn't matter.

@SamDW96
Copy link

SamDW96 commented Feb 20, 2023

Having the same issue. Win11, installer version, default install path (C:\Program Files\DLSS Swapper).

@Wxgner
Copy link

Wxgner commented Feb 28, 2023

Same here
W11/Default install

@Endebert
Copy link

Endebert commented Mar 7, 2023

I have the same issue, however the cause is regarding Ubisoft connect:

UbisoftConnectLibrary.cs:91 ListGamesAsync - Could not load Ubisoft Connect item.

@beeradmoore
Copy link
Owner

I don't believe that is the cause, I get these and still am unable to replicate the error in OP.

That line indicates that there was an error loading a game (or the location of the game library), logged it, and moved on. If anything it just means not all of your Ubisoft games are showing.

I will double check to confirm this is correct or not.

@Endebert
Copy link

Endebert commented Mar 8, 2023

@beeradmoore Just tried again, the log entries are created on app launch / on games refresh, so you are probably correct.

Here's all the info I can give you:

  • Windows 11 22H2 (Build 22621.1265)
  • installer version location: C:\Program Files\DLSS Swapper
  • Tried the portable version - same issue
  • Tried running as admin - same issue
  • In my case, the only log entries are the ones mentioning UbisoftConnectLibrary. E.g.:
    2023-03-08 18:11:22.898 +01:00 [ERR] UbisoftConnectLibrary.cs:91 ListGamesAsync - Could not load Ubisoft Connect item.
    2023-03-08 18:11:22.906 +01:00 [ERR] UbisoftConnectLibrary.cs:91 ListGamesAsync - Could not load Ubisoft Connect item.
    2023-03-08 18:11:22.907 +01:00 [ERR] UbisoftConnectLibrary.cs:91 ListGamesAsync - Could not load Ubisoft Connect item.
    
  • The wheel only spins for a moment + when I click on it, but nothing happens.

Here's a short video to demonstrate the behaviour:

dlss_swapper_settings_bug.mp4

Let me know if there's anything I else I can do to help.

@beeradmoore
Copy link
Owner

Thanks heaps for all that extra info!

What I think I'll do is make a 1.0.1 with command line options to disable all stores and options to disable auto-loading of games (you would manually have to hit the refresh button until a cache is added).

Theory being if it is the stores or it is a particular game that is failing and not erroring we can narrow it down further.

@Krasto82
Copy link

Krasto82 commented Apr 6, 2023

Same issue here. Win 11 both version.

@Klajan
Copy link

Klajan commented May 10, 2023

I think I found the problem.
The page string that is checked in the GoToPage function in MainWindows.xaml.cs is localised for the Settings Page

Since settings does not have a defined tag, one should check args.IsSettingsInvoked in MainNavigationView_ItemInvoked
A crude but simple fix would be to have:

if (args.IsSettingsInvoked)
{
    GoToPage("Settings");
} else if (args.InvokedItem is String invokedItem)
{
    GoToPage(invokedItem);
}

@beeradmoore
Copy link
Owner

beeradmoore commented Jun 18, 2023

Sorry I didn't see that reply @Klajan. I think you might be 100% right. When I can I'll confirm this and release a small update with that fix.

EDIT: That string is not localised by us and there is no plan yet to add localisation (although that would be great). It looks like we can use what you did and instead of the string we are using we instead do

if (args.IsSettingsInvoked)
{
    GoToPage("Settings");
}
else
{
    GoToPage(args.InvokedItemContainer.Tag);
}

which will use the Tag property defined elsewhere and does not rely on something that could be translated in the future.

@beeradmoore
Copy link
Owner

This has been implemented. I'll close the issue when v1.1 (or more likely v1.0.2) is released.

@beeradmoore
Copy link
Owner

v1.0.2 is now release with this fix. Special thanks again to @Klajan for pointing out the underlying issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests