Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastgenre: add classical music genre in the tree #1239

Closed
ghost opened this issue Jan 18, 2015 · 1 comment
Closed

Lastgenre: add classical music genre in the tree #1239

ghost opened this issue Jan 18, 2015 · 1 comment
Labels
feature features we would like to implement

Comments

@ghost
Copy link

ghost commented Jan 18, 2015

[21:44:38] Hi, I see nothing about classical music in the genres-tree.yaml file (lastgenre plugin). Any reason why? Are you waiting for contributions?
[21:45:46] Seems like a reasonable addition; I just think it didn't show up in our scraper strategy.
[22:13:42] Ok, I will see if I can contribute. I don't know much about it
[22:50:33] SuperDupont: Feel free to ask if you need help to grok how the file is built up. Also be sure to look at genres.txt - that's the file for the actual whitelisted tags getting pulled from last.fm.

Based on genres.txt, here is a proposition with "classic" as the main genre and with these subgenres:
ballet
baroque music
concerto grosso
cantata
cantique
chamber music
classical music
concerto
gregorian chant
impressionist music
opera
oratorio
orchestra
organum
requiem
string quartet
symphony

Tags that do not appear in genres.txt, but that seem popular on last.fm:
baroque
classical
contemporary classical
modern classical
orchestral
sacred music
symphonic
They could be added to both genres.txt genres.yaml

@sampsyo
Copy link
Member

sampsyo commented Jan 18, 2015

Looks good. Could you please make eye change and open a pull request? To do so, you may need to figure out the right nesting for the canonicalization tree.

@sampsyo sampsyo added the feature features we would like to implement label Jan 18, 2015
@Freso Freso closed this as completed in 61797e7 Jan 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

1 participant