Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedart: Prompt for confirmation in command #1999

Closed
taylorthurlow opened this issue May 11, 2016 · 2 comments
Closed

embedart: Prompt for confirmation in command #1999

taylorthurlow opened this issue May 11, 2016 · 2 comments
Labels
feature features we would like to implement

Comments

@taylorthurlow
Copy link

taylorthurlow commented May 11, 2016

Most commands will prompt for changes when altering files as such:

$> beet modify -a album:"penguin prison" year=2011 month=10 day=18
Modifying 1 albums.
Penguin Prison - Penguin Prison
    month: 08 -> 10
    day: 00 -> 18
Really modify, move and write tags (Y/n)?

However, the current implementation of embedart has no such prompts - nor does it provide any sort of output as to which files/albums it is currently editing (at least usually). A simple confirmation prompt to confirm that the proposed changes are desired would be much more ideal:

$> beet embedart -f artwork.jpg album:"penguin prison"
Modifying 1 albums.
Penguin Prison - Penguin Prison
    Existing embedded artwork (300x294)
    Replacement artwork (800x800)
Really write artwork to files (Y/n)?

More than once I have fudged up the syntax or accidentally pressed enter when trying to insert a quote. It is a bit too eager to try and write the input artwork to every file in your library!

Thanks for beets by the way - it's absolutely invaluable.

@taylorthurlow taylorthurlow changed the title Prompt for changes when using embedart plugin Prompt for changes when using embed art plugin (feature request) May 11, 2016
@taylorthurlow taylorthurlow changed the title Prompt for changes when using embed art plugin (feature request) Prompt for changes when using embedart plugin May 11, 2016
@sampsyo sampsyo changed the title Prompt for changes when using embedart plugin embedart: Prompt for confirmation in command May 11, 2016
@sampsyo sampsyo added the feature features we would like to implement label May 11, 2016
@sampsyo
Copy link
Member

sampsyo commented May 11, 2016

Sounds like a good idea.

@taylorthurlow
Copy link
Author

Per #2422 this looks like it's solved. Cheers to everyone involved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

2 participants