-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acousticbrainz: Submit analyses upstream to AB #2253
Comments
Yes; thanks for opening a reminder ticket! |
I'd like to pick this u if possible. |
Wonderful! Let's do it. This task has two parts: running the analysis program to get data and submitting the results to the web service API. Both start with information gathering: you'll want to look into the details for how to go both things and discuss your findings here. Sound good? |
Sound perfect! Here's my research:
Uploading:
|
Really awesome; thank you for looking into it! This all checks out, and it sounds like it should make the implementation relatively straightforward. We can just run the extractor agains the files and use The only tricky part is that we'll need to compute the hash of the extractor executable, which we can do in a way similar to this: https://github.com/MTG/acousticbrainz-client/blob/c135a557c61984effcdb9d7a0c2686a64829b217/abz/config.py#L115-L118 Not too hard! So I think the next step is to start making the plugin skeleton. Maybe a good place to start would be to look at the Let us know if any other advice would be helpful! |
Originally planned for being part of #1629 (which was resolved with #1787), the feature for the "acousticbrainz" plugin to run the analysis locally and submit results back to AcousticBrainz never made it in. It would still be a neat thing to have though. :)
The text was updated successfully, but these errors were encountered: