You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The execution exits with an error if mp3val or flac validators aren't installed. On the other hand, for extensions other than mp3 or flac which aren't included in the plugin's config, information is logged that the validator is missing and the execution moves on to checking the rest of the files.
I think this behaviour should be consistent for all extensions, also in cases when a validator is specified in the plugin's config, but it's not actually installed.
I am happy to send a PR with a fix for this!
The text was updated successfully, but these errors were encountered:
sampsyo
changed the title
Badfiles plugin: continue to other files if no validator was found for an extension
badfiles: Continue to other files if validator command is not found or exits with an error
Feb 8, 2017
Good call! Yes, this is definitely how it should work—it should use self._log.error() to produce an error message and just continue on instead of halting the whole process.
The execution exits with an error if mp3val or flac validators aren't installed. On the other hand, for extensions other than mp3 or flac which aren't included in the plugin's config, information is logged that the validator is missing and the execution moves on to checking the rest of the files.
I think this behaviour should be consistent for all extensions, also in cases when a validator is specified in the plugin's config, but it's not actually installed.
I am happy to send a PR with a fix for this!
The text was updated successfully, but these errors were encountered: