Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaygain album gain per disc support #293

Closed
yoasif opened this issue May 28, 2013 · 6 comments
Closed

Replaygain album gain per disc support #293

yoasif opened this issue May 28, 2013 · 6 comments
Labels
feature features we would like to implement

Comments

@yoasif
Copy link
Contributor

yoasif commented May 28, 2013

It'd be nice to be able to Replaygain albums with a per disc album gain grouping.

So if I had a two CD album (using disc tags), each disc would have it's album gain calculated by itself, irrespective of the other discs in the same album.

@sampsyo
Copy link
Member

sampsyo commented May 28, 2013

To clarify: The RG standard doesn't have per-disc gain fields. But we could abuse the album gain field to store that information. Would that suffice?

@yoasif
Copy link
Contributor Author

yoasif commented May 29, 2013

@sampsyo Yes, that is exactly what I was thinking (and how I currently do it using foobar2000).

@sampsyo
Copy link
Member

sampsyo commented May 29, 2013

Great. In case you're interested in hacking on this, it should be a relatively straightforward implementation.

@samuelnilsson
Copy link
Contributor

Hi!

I'm opening this up almost 6 years later. I'm also interested in this feature and could try to implement it if it is not too time consuming. Do @sampsyo, who has more insight of the code, still believe this should be relatively straightforward? Personally I don't believe that it seems too complicated to achieve when looking at the plugin code.

However, one issue is that the rg_album_gain and r128_album_gain are album level fields. Will that structure need to be changed since, when implementing this, the items on an album could have different album gain values?

@sampsyo
Copy link
Member

sampsyo commented Jan 25, 2019

Sure! I agree that it shouldn’t be too complex.

It is unfortunate, but you’re also right that we may need to “demote” those fields to item-level fields. It is also technically possible, although a little weird, for items to “disagree” even on album-level fields—nothing actually prevents that from happening. So maybe it’s worth a try without changing the status of those fields, and we can revisit the decision if it causes problems.

@arcresu
Copy link
Member

arcresu commented Jun 11, 2019

Closed in #3137

@arcresu arcresu closed this as completed Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants