Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetchart: Support downloading all image types #3543

Closed
hashhar opened this issue Apr 6, 2020 · 3 comments
Closed

fetchart: Support downloading all image types #3543

hashhar opened this issue Apr 6, 2020 · 3 comments
Labels
duplicate feature features we would like to implement

Comments

@hashhar
Copy link
Contributor

hashhar commented Apr 6, 2020

Use case

I'm trying to use beets to replicate some functionality from MusicBrainz Picard where it allows selecting from a checklist of different cover image (and PDF) types (front, back, spine, booklet etc.) and downloads and names all of them to the music directory.

The fetchart plugin today can only download a single image and give a single filename.

Solution

Modify the fetchart plugin to be able to return a dict of images keyed by ID3 image types and add a field/flexattr called coverart_type so that it can be used as a template variable in the art_filename config field.

@sampsyo sampsyo changed the title fetchart: support downloading all image types fetchart: Support downloading all image types Apr 7, 2020
@sampsyo sampsyo added the feature features we would like to implement label Apr 7, 2020
@sampsyo
Copy link
Member

sampsyo commented Apr 7, 2020

Sounds good! For what it's worth, this will be a bit more complex to implement than it may seem at first because beets does not support an arbitrary number of image "attachments" to a given album. There is a single fixed-function field for keeping track of album art files. We would need to generalize this (along the lines of #111, even if it's not that general) to track multiple images in the database.

@hashhar
Copy link
Contributor Author

hashhar commented Apr 7, 2020

@sampsyo Thanks for pointing to that link but it seems like beets fell down my priority of things to use since I figured out a workflow to let MusicBrainz Picard do all the tagging, file organisation etc and leaving beets to only handle duplicates, lyrics and missing tracks.

I'll definitely try looking this over the weekend since I feel beets is a very useful tool to explore/use my extensive music library. Query based playlists, transcoding etc.

@wisp3rwind
Copy link
Member

wisp3rwind commented Apr 10, 2020

Note that this idea isn't new: #3173, so I'm going to close this as a duplicate. But as pointed out by @sampsyo, the 'correct' solution in beets' ecosystem is through implementing the attachment proposal, which is a non-trivial issue that has not been tackled in a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

3 participants