Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"the" plugin uses incorrect regex #3701

Closed
gschmidl opened this issue Jul 30, 2020 · 0 comments · Fixed by #3702
Closed

"the" plugin uses incorrect regex #3701

gschmidl opened this issue Jul 30, 2020 · 0 comments · Fixed by #3702

Comments

@gschmidl
Copy link
Contributor

Problem

Running this command:

~ ❯ beet move artist:trance -p
Moving 40 items.
M:\TET - Travailleur En Trance\[2008] Cobra Coded Escalation\01-01 - Cobra Reporting In.mp3
  -> M:\‒ Travailleur En Trance, TET\[2008] Cobra Coded Escalation\01-01 - Cobra Reporting In.mp3

Led to this problem:

"TET" is recognized by the "the" plugin as something it should move. This is because the regex used in the.py, line 26, is

PATTERN_THE = u'^[the]{3}\\s'

which matches "TET". It should probably be:

PATTERN_THE = u'^the\\s'

Setup

  • OS: Windows 10 2004
  • Python version: 3.8
  • beets version: latest trunk
  • Turning off plugins made problem go away (yes/no): obviously, if I disable 'the' it no longer does this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant