cover art problems

[mfiano]

Multiple issues with cover art here.

1. Never ever duplicate cover art. On multiple ocassions, I came across cover art not being overwritten and instead making duplicates like cover.1.jpg, cover.2.jpg, etc.

2. The real problem here is the last duplicate filename. say cover.2.jpg is the one added to the database. So if I have 3 covers when I should have 1, and I delete cover.1.jpg and cover.2.jpg, then doing a beet mv will fail due to cover.2.jpg not being present.

[sampsyo]

Now that I think about this more, this is actually the same problem as #314. The root cause is that, during re-imports, the fetchart plugin is happy to identify the old cover art as new cover art and to helpfully copy that into the "destination" directory for you. This leads to duplicating, rather than moving art.

The solution is probably to make the re-import flow aware of cover art. The fetchart plugin should probably detect that cover art is already present and not try to rediscover it.