Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbsubmit: Allow submitting release after initial import #5032

Open
arsaboo opened this issue Dec 6, 2023 · 4 comments
Open

mbsubmit: Allow submitting release after initial import #5032

arsaboo opened this issue Dec 6, 2023 · 4 comments
Labels
feature features we would like to implement

Comments

@arsaboo
Copy link
Contributor

arsaboo commented Dec 6, 2023

Thanks @doronbehar, for the recent additions to the mbsubmit plugin #4807. Currently, the plugin only allows submission only on initial import. We should also extend the mbsubmit command to submit the release after the initial import.

Specifically, in addition to the track listing, beet mbsubmit album:"XYZ" should also give an option to Open files with Picard.

@doronbehar
Copy link
Contributor

Specifically, in addition to the track listing, beet mbsubmit album:"XYZ" should also give an option to Open files with Picard.

Just to make sure I understand, are you describing a scenario that the user has imported an album's folder "as is" or via a spotify / discogs release (via the relevant plugins) and then they wish to submit it to MusicBrainz?

@arsaboo
Copy link
Contributor Author

arsaboo commented Dec 6, 2023

That is correct...the album is already imported to the beets library with any of the tag sources (e.g., Spotify) and needs to be submitted to MB.

@sampsyo sampsyo added the feature features we would like to implement label Dec 10, 2023
@Kyubai
Copy link

Kyubai commented Feb 17, 2024

This would help me a lot.
Currently mbsubmit is using before_choose_candidate_listener, but it would have to trigger after the candidate (spotify, deezer, etc. match) has been chosen.

Here's an example:

image

As you can see spotify provides the correct album info, but pressing p only prints the information from my local file.
Once I choose Apply beets will move on the the next track and I can't print the correct metadata anymore

@doronbehar
Copy link
Contributor

@Kyubai are you using the latest unreleased beets? With #4807 included? I'm not sure I understand what you are trying to say about the event before_choose_candidate_listener - The menu you showed above should I think give you the prompt choice to open the files with Picard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

No branches or pull requests

4 participants