Regression in 2.0.0: import UI is useless in ligth theme #5342
Comments
|
You can configure the colors: https://beets.readthedocs.io/en/stable/reference/config.html#colors |
|
@arsaboo yes, I can. But this bug can be reproduced with default setting of Xterm. |
|
Do you have a suggested fix for this @catap? It seems relatively easy to change from a user's settings. Perhaps a change of the default colours for people who haven't set it specifically? |
|
I think that default settings should be useful for both dark and light themes, at least it was true before 2.0.0 |
|
Just for records, here how it looks at default settings of xterm:
|
|
The next step, I've tried to use |
|
Probably a way to fix it. First, we need to move to 4-bit ansi colors as: modified beets/ui/__init__.py
@@ -533,6 +533,14 @@ ANSI_CODES = {
"magenta": 35,
"cyan": 36,
"white": 37,
+ "bright_black": 90,
+ "bright_red": 91,
+ "bright_green": 92,
+ "bright_yellow": 93,
+ "bright_blue": 94,
+ "bright_magenta": 95,
+ "bright_cyan": 96,
+ "bright_white": 97,
# Background colors.
"bg_black": 40,
"bg_red": 41,
@@ -542,6 +550,14 @@ ANSI_CODES = {
"bg_magenta": 45,
"bg_cyan": 46,
"bg_white": 47,
+ "bg_bright_black": 100,
+ "bg_bright_red": 101,
+ "bg_bright_green": 102,
+ "bg_bright_yellow": 103,
+ "bg_bright_blue": 104,
+ "bg_bright_magenta": 105,
+ "bg_bright_cyan": 106,
+ "bg_bright_white": 107,
}
RESET_COLOR = COLOR_ESCAPE + "39;49;00m"
after that I may use bright colors as: modified beets/config_default.yaml
@@ -122,7 +122,7 @@ ui:
text_warning: ['bold', 'yellow']
text_error: ['bold', 'red']
text_highlight: ['bold', 'red']
- text_highlight_minor: ['white']
+ text_highlight_minor: ['bright_white']
action_default: ['bold', 'cyan']
action: ['bold', 'cyan']
# New Colors
@@ -130,16 +130,16 @@ ui:
text_faint: ['faint']
import_path: ['bold', 'blue']
import_path_items: ['bold', 'blue']
- added: ['green']
- removed: ['red']
- changed: ['yellow']
+ added: ['bright_green']
+ removed: ['bright_red']
+ changed: ['bright_yellow']
added_highlight: ['bold', 'green']
removed_highlight: ['bold', 'red']
changed_highlight: ['bold', 'yellow']
text_diff_added: ['bold', 'red']
text_diff_removed: ['bold', 'red']
text_diff_changed: ['bold', 'red']
- action_description: ['white']
+ action_description: ['bright_white']
import:
indentation:
match_header: 2which leads to UI like:
|
|
Or, without any new collors: ui:
terminal_width: 80
length_diff_thresh: 10.0
color: yes
colors:
text_success: ['bold', 'green']
text_warning: ['bold', 'yellow']
text_error: ['bold', 'red']
text_highlight: ['bold', 'red']
text_highlight_minor: ['bold', 'white']
action_default: ['bold', 'cyan']
action: ['bold', 'cyan']
# New Colors
text: ['normal']
text_faint: ['faint']
import_path: ['bold', 'blue']
import_path_items: ['bold', 'blue']
added: ['bold', 'green']
removed: ['bold', 'red']
changed: ['bold', 'yellow']
added_highlight: ['bold', 'green']
removed_highlight: ['bold', 'red']
changed_highlight: ['bold', 'yellow']
text_diff_added: ['bold', 'red']
text_diff_removed: ['bold', 'red']
text_diff_changed: ['bold', 'red']
action_description: ['bold', 'white'] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
When someoen uses non dark theme, like me for last couple of weeks, it leads to almost not usefull UI.
See:
This is regression was introduced by #3721
You may reproduce it by using this xterm theme: https://github.com/janoamaral/Xresources-themes/blob/master/light/PaperColor.Xresources
Setup
My configuration (output of
beet config) is:The text was updated successfully, but these errors were encountered: