Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't run tests on cygwin #655

Closed
yevgenybezman opened this issue Apr 4, 2014 · 3 comments
Closed

Can't run tests on cygwin #655

yevgenybezman opened this issue Apr 4, 2014 · 3 comments
Labels
bug bugs that are confirmed and actionable

Comments

@yevgenybezman
Copy link
Contributor

The common module tries to rmtree the temporary directory created for each test.
Since the library file is still open, and Windows doesn't allow deleting an open file, this fails.
Adding True as the second argument (ignore errors) fixes the problem (tests pass, directory not deleted). A more thorough fix is needed.

@sampsyo
Copy link
Member

sampsyo commented Apr 4, 2014

That's unfortunate. I'm guessing this is a problem on vanilla Windows too, not just Cygwin.

I suppose we need to be more careful about closing the library DB on cleanup.

@yevgenybezman
Copy link
Contributor Author

Still doesn't pass, but much better. I'll fix what's left.

@sampsyo
Copy link
Member

sampsyo commented Apr 16, 2014

See #670 for some notes on general Windows stuff I've been fixing (and been stymied by).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs that are confirmed and actionable
Projects
None yet
Development

No branches or pull requests

2 participants