Bug: Does group-albums use ../$album%aunique{}/.. as the path by default?
#764
Comments
|
Hmm, it sounds like the issue is that the group-albums setting detected that these were different albums. (The disambiguation string appearing is just a symptom of that fact and not a problem.) Can you provide more details on the metadata of those files? We should be able to identify why group-albums thought there were many different albums. For example, it could be getting tripped up by featuring artists. |
|
I know for sure those 10-12 files in each album had exactly the same album name. I however updated them using |
|
Everything works fine in testing here. We'll need specimens of files that cause this behavior reproducibly to diagnose it—please reopen this issue if you come across any more. |
|
I found a similar problem with another album. I have five tracks from the album 'Recovery'. They were in a directory along with other songs from different albums. I imported that dir using Querying the library like so gives the following output: clearly beets is regarding them as different albums. How do I "merge" these into a single album entry in the library database? |
|
Do you have the original (unmodified, pre-import) files so we can run some experiments? FWIW, the grouping depends on the artist, album artist, and album fields on the original files: https://github.com/sampsyo/beets/blob/master/beets/importer.py#L1084 If you're interested in post-facto regrouping of albums, see #112. |
|
I don't think I have the original files. I should start making copies of what I am about to import! Also, is the grouping done before or after auto-tagging? If its done after, then the problem might be with unreliable and not necessarily accurate tags in the unimported files, due to which they might have been grouped separately. |
|
Yes, grouping is done as a pre-processing step before autotagging. (Grouping afterward wouldn't work very well since they would already have uniform tags as a single album. The point of the feature is to tag the files as separate albums.) So it's almost certainly because the original metadata is slightly inconsistent (different artist name spelling, for example). |
|
I removed those albums from the beets library and then again imported those five tracks (as a single album) which worked correctly. I think Few ideas as to how to approach that:
|
|
Fuzzy matching does seem like a good idea. Do you mind opening a separate issue to make that into a feature request? We'll need some examples to use as robustness test cases. Tagging separately seems rather slow (requiring many more trips to MusicBrainz) but could work. Grouping manually is also an option, but that doesn't offer too much over having the user manually group files into directories, and it's unclear how the UI should work. |
|
Hi @sampsyo, I sent you some example files via WeTransfer. |
|
Hi, @linkdaniel! I don't quite see what's going on from the files—can you please file a new bug with full details (i.e., what you expected to happen, and any guesses as to what went wrong from your perspective)? |
|
@sampsyo Perhaps you didn't see the message that came with the files. They belong to the same album, and $albumartist as well as $album have the same values. I'd expect beets to disambiguate nothing. Instead, it should organize all files into just one folder. I'm using the default paths. I'm using the beets version that is included in Mint 18 Cinnamon, plus some plugins: |
|
OK, thanks for including that here! Having details on the public bug tracker is important so everyone can see and help out. Does this still happen if you try it again with the latest release of beets? |
|
I can tell when the latest release makes it to the Mint repository. If it doesn't happen on your computer with the files I sent you, I guess it's ok now. |
|
OK. You can also try installing with pip to get the latest version. |
|
That's a good idea, thanks! Installed it: Issued beet update and beet move. The album is still distributed over 16 or so folders, unfortunately. |
|
OK, thanks for giving that a try! To finish completing the report, could you perhaps include your configuration and the verbose output of running an |
|
Reimporting the files correctly placed them in just one folder. See below for the verbose output. Shouldn't |
|
No, reimporting gives the importer another chance to group items into albums. So has the problem vanished, or is there something we can try to reproduce? |
|
I don't understand why I should have to reimport albums so that beets would organize them correctly. This should not be necessary. But if you say that's just how it is, I guess there's issue with the move command. Thanks! |
|
Oh no, sorry! That's not what I meant to say at all. I just need a way to reproduce the original problem, or at least see the verbose output from a run that has the problem. Any chance you can recreate that? We know something's wrong, but I can't see what quite yet. |
|
Ah, ok, now I get it. Sorry. :) |
|
Sure—the most helpful thing would be to see the verbose log from an import that leads to this problem. That is, you've run both original imports, which led to a bunch of separate albums in your library, and re-imports, which fixed the problem. A -vv log from the former would be most useful. |
|
I'll try to do this when I'm back home in a few weeks and can access the original files again. I hope the files will import just fine, as this would mean an import issue has already been fixed in the current beets version. |
I had a directory with many songs from an artist spanning 4-5 albums, all tagged correctly.
I imported them using
and
beetscreated a new folder for each song in every album. I ended up having 10-12 folders per album likeHybrid Theory <some_number>, each with one or two songs in them.I think this happened because of the album disambiguation thingy.
I then set the default path in my
configfile to$albumartist/$album/$track $title, and reimported that whole dir. It worked as expected.I am not able to isolate this setting in the code, but I think
group-albumsfeature should leave the disambiguation setting out.The text was updated successfully, but these errors were encountered: