Replies: 2 comments 1 reply
-
Hi Igor, I agree with everything you've suggested. Dropping the lightbox functionality would be the best way forward in my opinion and would make for a small, efficient and clean library with a concise API, like you say. Adding lightbox functionality as an external call (react callback/hook/whatever) would be trivial for the user to implement. Once react-images is stripped out the library, we can probably bump react-grid-gallery versioning up to 1.x.x. |
Beta Was this translation helpful? Give feedback.
-
Thank you @itoldya and @benhowell for putting some much TLC in the project! I also add +1 to drop functionality in favor of ensuring the maintainability and future for the component. However this seems to be already "done"? |
Beta Was this translation helpful? Give feedback.
-
Hi, I'm Igor 👋
I’ve recently been working on resolving existing issues and have to admit that most of them cannot be resolved without serious changes.
The number one problem now is the external dependency on
react-images
.The current version we use isn't working correctly on React >16. There is a new version of the package which I suppose works on React 17, but it's marked as not recommended to use in the new projects.
I guess it's possible to find a stable replacement for
react-images
, but of course, we cannot change the lightbox provider seamlessly. It will cause our API to change because we are dependent on exact implementation.Also, we have to take risks that the replacement can also become out of date one day.
And even with a new lightbox, it will be not easy to provide customization asked in the issues.
So that's why I want to suggest dropping lightbox functionality out of
react-grid-gallery
and instead focusing on building a beautiful justified grid library with selection functionality.It'll give us the way to upgrade to the latest React version and resolve all warnings. Also, it means
As the library focused on the justified grid we would implement new features in the future such as
Of course, I understand that some users still wanted to use a grid with a lightbox, so I suggest adding a docs section with examples of integrations for different use cases
So what do you think of this?
I understand this repo had been abandoned for a while and there is no active community around React Grid Gallery. But don't let it stop you from leaving your opinion here. I really appreciate it. Thanks!
Beta Was this translation helpful? Give feedback.
All reactions