Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How do you display transparent images without artefacts in Kitty? #48

Closed
hankertrix opened this issue Oct 14, 2024 · 1 comment

Comments

@hankertrix
Copy link

hankertrix commented Oct 14, 2024

This should be a discussion, but discussions are not enabled on this project.

I am trying to fix this issue in Yazi, but I have no idea what is being done differently such that this library previews the transparent images just fine, but Yazi's previewer has artefacts.

Here is the code for image previewing using the Kitty graphics protocol in Yazi:
https://github.com/sxyazi/yazi/blob/main/yazi-adapter/src/kgp.rs

I looked through it and think the main difference is in the render function in this library and the place function in Yazi, with this library skipping after each write.

@hankertrix
Copy link
Author

Sorry about the noise, it has been implemented in Yazi and I didn't realise.

@hankertrix hankertrix closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant