Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is $ a valid module name? #243

Open
filipenevola opened this issue Jan 17, 2021 · 1 comment
Open

Is $ a valid module name? #243

filipenevola opened this issue Jan 17, 2021 · 1 comment

Comments

@filipenevola
Copy link

Hi @benjamn, we got this issue on Meteor meteor/meteor#11279

I believe it is because X6 is using import $ and then reify is breaking in this case.

Am I right? Is this a valid module name?
@benjamn
Copy link
Owner

benjamn commented Jan 19, 2021

@filipenevola Yes, $ is a valid identifier (variable name), so it should be importable/exportable.

@filipenevola filipenevola mentioned this issue Jan 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamn @filipenevola