Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile issue #22

Closed
rdbauer opened this issue Mar 20, 2016 · 4 comments
Closed

Mobile issue #22

rdbauer opened this issue Mar 20, 2016 · 4 comments

Comments

@rdbauer
Copy link

rdbauer commented Mar 20, 2016

I found this plugin and it looks and works great from what I can tell this far. I am looking forward to getting to use it on our project. I was just viewing the demo tour on my phone and noticed that the 4th step (the start of the table) has the "tooltip" off to the left. While I don't remember having any issue with it on my desktop yesterday, on my phone it is off the screen and I have no way of "scrolling over" to it or anything, hence leaving me unable to continue or close the tour. I have no current tests with it or fixes as of yet. I just didn't know if you were aware of this and if it is a bug or just a styling issue that I will have to avoid when I implement this.

Great work!

@benmarch
Copy link
Owner

Hi @rdbauer, I noticed a similar issue the other day when I had a 100%-width div and positioned the step to the left. I am currently using Angular UI's tooltips to handle the position for me, so I wonder if there is a configuration option to prevent them from appearing off screen. I will look into this and see if it can be done out of the box. If not, I'll add it to the back log for the next releases. Using a top- or bottom-positioned step should prevent this in the meantime.

Thanks,
Ben

@rdbauer
Copy link
Author

rdbauer commented Mar 20, 2016

That is what I was figuring. I did read that angular-ui is working on it. Discussion is in angular-ui/bootstrap#4762.

@benmarch
Copy link
Owner

Yeah I might just wait for them to fix it. I tried using "auto left" per their recommendation but it really doesn't work right.

@benmarch
Copy link
Owner

I played around with this a bit over the weekend, but because of its complexity, and the fact that the UI team is already working on it, I am going to leave it to them. Thank you for your interest in this plugin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants