Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apparent corner case with import/no-commonjs rule #1354

Merged
merged 1 commit into from
May 6, 2019

Conversation

charlessuh
Copy link

@charlessuh charlessuh commented May 5, 2019

var x = require("x") will throw an error, but var x; x = require("x") does not.

@charlessuh charlessuh changed the title Assign no commonjs Fix apparent corner case with import/no-commonjs rule May 5, 2019
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 5d05134 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

@coveralls
Copy link

coveralls commented May 6, 2019

Coverage Status

Coverage increased (+2.5%) to 97.937% when pulling 1edbbd0 on charlessuh:assign-no-commonjs into f63dd26 on benmosher:master.

@charlessuh charlessuh force-pushed the assign-no-commonjs branch from 5d05134 to 77390d2 Compare May 6, 2019 08:23
@ljharb ljharb force-pushed the assign-no-commonjs branch from 77390d2 to 1edbbd0 Compare May 6, 2019 17:56
@ljharb
Copy link
Member

ljharb commented May 6, 2019

I think this can be called a bugfix, even though it will cause more warnings to be issued.

@ljharb ljharb added the bug label May 6, 2019
@ljharb ljharb merged commit 1edbbd0 into import-js:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants