From 420153472772bb8367e135fdd908639c6ba36788 Mon Sep 17 00:00:00 2001 From: "Ben Sheldon [he/him]" Date: Wed, 7 Aug 2024 11:05:02 -0700 Subject: [PATCH] Add appraisal for Rails 7.2; bracket lowest PG version instead of enumerating all (#1460) --- .github/workflows/test.yml | 11 ++---- Appraisals | 6 ++++ gemfiles/rails_7.2_ruby_3.1.gemfile | 53 +++++++++++++++++++++++++++++ 3 files changed, 61 insertions(+), 9 deletions(-) create mode 100644 gemfiles/rails_7.2_ruby_3.1.gemfile diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 16a5a156..165eb816 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -41,7 +41,7 @@ jobs: DISABLE_SPRING: 1 services: postgres: - image: postgres:15 + image: postgres:16 env: POSTGRES_USER: good_job POSTGRES_DB: good_job_test @@ -97,14 +97,7 @@ jobs: include: - ruby: 3.3 pg: 11 - - ruby: 3.3 - pg: 12 - - ruby: 3.3 - pg: 13 - - ruby: 3.3 - pg: 14 - - ruby: 3.3 - pg: 15 + env: PGHOST: localhost PGUSER: good_job diff --git a/Appraisals b/Appraisals index 5621e8c4..e9be7e73 100644 --- a/Appraisals +++ b/Appraisals @@ -33,6 +33,12 @@ if ruby_31_or_higher gem "selenium-webdriver", "~> 4.0" # https://github.com/rails/rails/pull/43498 end + appraise "rails-7.2-ruby-3.1" do + gem "capybara", "~> 3.36" # For Ruby 3.1 support https://github.com/teamcapybara/capybara/pull/2468 + gem "rails", "~> 7.2.0.a" + gem "selenium-webdriver", "~> 4.0" # https://github.com/rails/rails/pull/43498 + end + appraise "rails-head" do gem "capybara", "~> 3.36" # For Ruby 3.1 support https://github.com/teamcapybara/capybara/pull/24 gem "rails", github: "rails/rails", branch: "main" diff --git a/gemfiles/rails_7.2_ruby_3.1.gemfile b/gemfiles/rails_7.2_ruby_3.1.gemfile new file mode 100644 index 00000000..20aa98ee --- /dev/null +++ b/gemfiles/rails_7.2_ruby_3.1.gemfile @@ -0,0 +1,53 @@ +# This file was generated by Appraisal + +source "https://rubygems.org" + +gem "activerecord-jdbcpostgresql-adapter", platforms: [:jruby] +gem "appraisal" +gem "matrix" +gem "nokogiri" +gem "pg", platforms: [:mri, :mingw, :x64_mingw] +gem "rack", "~> 2.2" +gem "rails", "~> 7.2.0.a" +gem "capybara", "~> 3.36" +gem "selenium-webdriver", "~> 4.0" + +platforms :ruby do + gem "bootsnap" + gem "dotenv-rails" + gem "foreman" + gem "gem-release" + gem "github_changelog_generator", require: false + gem "net-imap", require: false + gem "net-pop", require: false + gem "net-smtp", require: false + + group :debug do + gem "activerecord-explain-analyze", require: false + gem "pry-byebug" + gem "rack-mini-profiler" + gem "rbtrace" + gem "stackprof" + end + + group :lint do + gem "easy_translate" + gem "erb_lint" + gem "i18n-tasks" + gem "mdl" + gem "rubocop" + gem "rubocop-performance" + gem "rubocop-rails" + gem "rubocop-rspec" + gem "sorbet" + gem "sorbet-runtime" + gem "spoom", require: false + gem "tapioca", require: false + end + + group :demo, :production do + gem "skylight" + end +end + +gemspec path: "../"