Run tests with warnings enabled (#1462)

* Remove format constraint from `frontend/static` route

`format` doesn't accept an array. This currently creates a format constraint that looks like this,
and emits a warning because characters appear multiple times in the character class:
`/\A["css", "js", "svg"]\Z/`

The constraint is actually not needed, the controller already handles this.

* Resolve some test-only warnings

* Run tests with warnings enabled

config/routes.rb

@@ -39,6 +39,6 @@
 
   scope :frontend, controller: :frontends, defaults: { version: GoodJob::VERSION.tr(".", "-") } do
     get "modules/:version/:id", action: :module, as: :frontend_module, constraints: { format: 'js' }
-    get "static/:version/:id", action: :static, as: :frontend_static, constraints: { format: %w[css js svg] }
+    get "static/:version/:id", action: :static, as: :frontend_static
   end
 end

spec/spec_helper.rb

@@ -39,6 +39,8 @@
     mocks.verify_partial_doubles = true
   end
 
+  config.warnings = true
+
   # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
   # have no way to turn it off -- the option exists only for backwards
   # compatibility in RSpec 3). It causes shared context metadata to be

spec/support/reset_rails_queue_adapter.rb

@@ -6,12 +6,14 @@ module ActiveJob
   module TestHelper
     # Avoid calling #descendants because JRuby has trouble with it
     # https://github.com/jruby/jruby/issues/6896
+    silence_redefinition_of_method :queue_adapter_changed_jobs
     def queue_adapter_changed_jobs
       []
     end
 
     module TestQueueAdapter
       module ClassMethods
+        silence_redefinition_of_method :queue_adapter
         def queue_adapter # rubocop:disable Lint/UselessMethodDefinition
           super
         end

spec/support/selenium.rb

@@ -7,6 +7,7 @@
 module ActionDispatch
   module SystemTesting
     class Browser # :nodoc:
+      silence_redefinition_of_method :resolve_driver_path
       def resolve_driver_path(namespace)
         # The path method has been deprecated in 4.20.0
         namespace::Service.driver_path = if Gem::Version.new(::Selenium::WebDriver::VERSION) >= Gem::Version.new("4.20.0")