Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unexpected behavior for URLs for sets #1763

Open
mulcare opened this issue Jun 7, 2020 · 1 comment
Open

unexpected behavior for URLs for sets #1763

mulcare opened this issue Jun 7, 2020 · 1 comment

Comments

@mulcare
Copy link

mulcare commented Jun 7, 2020

I stumbled upon some odd URL behavior while creating a set: I realized that currently FromThePage seems to ignore the account with which a set is associated (i.e. the account that creates the set) when it comes to creating URLs.

You can see this here:

Though I think it's unlikely, this does have potential for being used to mislead people about the origin of projects and sets. It also has implications for SEO, should people start to tinker with the project name part of the path and spread the links around.

Perhaps most importantly, it prevents the creation of sets with the same name across top-level projects.

@benwbrum
Copy link
Owner

benwbrum commented Jun 9, 2020

That's a good find. Unfortunately, after we fix this, the friendly_id gem we use for generating slugs will probably continue to force site-wide uniqueness of project URLs unless we do some frightful hacking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants