Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 after logging in #3506

Closed
saracarl opened this issue Feb 15, 2023 · 3 comments · Fixed by #3507
Closed

404 after logging in #3506

saracarl opened this issue Feb 15, 2023 · 3 comments · Fixed by #3507
Labels

Comments

@saracarl
Copy link
Collaborator

I, [2023-02-15T19:11:06.077062 #25690]  INFO -- :   Parameters: {"authenticity_token"=>"T8xpJEr1m3YZi+zz8fPxBxljq3A4YdGmAWFVlmxYm2h/1KLUbHe6v9G8myiIC8Wt62LyKhj3nfLrVAW63deZWg==", "user"=>{"login_id"=>"demo", "password"=>"[FILTERED]", "remember_me"=>"0"}, "button"=>""}
I, [2023-02-15T19:11:06.114327 #25690]  INFO -- : Redirected to https://fromthepage.com/assets/footer-logo.svg
I, [2023-02-15T19:11:06.126502 #25690]  INFO -- : Completed 302 Found in 49ms (ActiveRecord: 15.2ms | Allocations: 10930)
I, [2023-02-15T19:11:06.127350 #25690]  INFO -- : Oink Action: devise/sessions#create
I, [2023-02-15T19:11:06.127734 #25690]  INFO -- : Memory usage: 11625640 | PID: 25690
I, [2023-02-15T19:11:06.128530 #25690]  INFO -- : Instantiation Breakdown: Total: 7 | User: 2 | Visit: 2 | FriendlyId::Slug: 1 | Notification: 1 | Ahoy::Event: 1
I, [2023-02-15T19:11:06.128836 #25690]  INFO -- : Oink Log Entry Complete
I, [2023-02-15T19:11:06.175525 #25690]  INFO -- : Started GET "/assets/footer-logo.svg" for 136.62.254.224 at 2023-02-15 19:11:06 +0000
I, [2023-02-15T19:11:06.178368 #25690]  INFO -- : Processing by CollectionController#show as SVG
I, [2023-02-15T19:11:06.178802 #25690]  INFO -- :   Parameters: {"user_slug"=>"assets", "id"=>"footer-logo"}
I, [2023-02-15T19:11:06.187807 #25690]  INFO -- :   Rendering inline template
I, [2023-02-15T19:11:06.189363 #25690]  INFO -- :   Rendered inline template (Duration: 0.9ms | Allocations: 81)
I, [2023-02-15T19:11:06.203027 #25690]  INFO -- : Redirected to https://fromthepage.com/404

@saracarl
Copy link
Collaborator Author

it actually logs me in...

@benwbrum
Copy link
Owner

These lines:

I, [2023-02-15T19:11:06.175525 #25690]  INFO -- : Started GET "/assets/footer-logo.svg" for 136.62.254.224 at 2023-02-15 19:11:06 +0000
I, [2023-02-15T19:11:06.178368 #25690]  INFO -- : Processing by CollectionController#show as SVG
I, [2023-02-15T19:11:06.178802 #25690]  INFO -- :   Parameters: {"user_slug"=>"assets", "id"=>"footer-logo"}

Result in a 404 because we're not using the asset pipeline to serve the landing page footer svg. The offending code is here and needs to be changed to an image tag helper as we did in the other landing pages.

The same problem exists on line 28 of the same file

It's not at all clear to me that this 404 is what the end user is seeing, because that shouldn't be served via the main browser page request.

@saracarl
Copy link
Collaborator Author

I can reproduce this in production, but the same user works fine in localhost.

@saracarl saracarl linked a pull request Feb 15, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants