Skip to content

Commit

Permalink
chore(cli): cleanup (#1378)
Browse files Browse the repository at this point in the history
* bet

* bet

* bet

* In the heart of Go, where code does flow,
Lies a pain that many know,
A struggle, a battle, a silent plea,
For generation to set us free.

Interfaces vast, generics in the fray,
Mocking them seems so far away.
Lines of code we must contrive,
To make our tests and functions thrive.

Oh, the templates, the scripts we write,
In the quiet hours of the night.
For every method, for every call,
We craft our mocks, we build them all.

Yet the syntax twists, the errors grow,
A tangled web, a thorny row.
With each new type, with each new case,
A fresh endeavor we must face.

We dream of tools, of magic wands,
To ease this task, to break these bonds.
But here we are, in the trenches deep,
Sowing seeds we'll one day reap.

So we persevere, with weary hands,
In this code's endless demands.
For in the end, when tests run green,
A glimmer of joy can be seen.

But until that day, we bear the strain,
Of Go's relentless, mocking pain.
A coder's burden, heavy and true,
In every line, in every view.

* bet
  • Loading branch information
archbear authored Jun 7, 2024
1 parent 8e06b9c commit 5df0891
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion mod/cli/pkg/commands/deposit/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const (
privateKey = "private-key"

// overrideNodeKey is the flag for overriding the commands key.
overrideNodeKey = "override-commands-key"
overrideNodeKey = "override-node-key"

// validatorPrivateKey is the flag for the validator private key.
valPrivateKey = "validator-private-key"
Expand Down
3 changes: 1 addition & 2 deletions mod/payload/pkg/builder/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ type Config struct {
// Enabled determines if the local builder is enabled.
Enabled bool `mapstructure:"enabled"`
// SuggestedFeeRecipient is the address that will receive the transaction
// fees
// produced by any blocks from this commands.
// fees produced by any blocks from this node.
SuggestedFeeRecipient common.ExecutionAddress `mapstructure:"suggested-fee-recipient"`
// PayloadTimeout is the timeout parameter for local build
// payload. This should match, or be slightly less than the configured
Expand Down
2 changes: 1 addition & 1 deletion testing/e2e/e2e_staking_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ func (s *BeaconKitE2ESuite) TestDepositRobustness() {
err = s.WaitForNBlockNumbers(20)
s.Require().NoError(err)

// Compare height of commands 1 and 2
// Compare height of nodes 1 and 2
height, err := client.ABCIInfo(s.Ctx())
s.Require().NoError(err)
height2, err := client2.ABCIInfo(s.Ctx())
Expand Down

0 comments on commit 5df0891

Please sign in to comment.