fix(log): add check keyVals invalid

[hoank101]

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in the logging functionality to prevent possible crashes when non-string keys are used.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The recent updates in the Logger struct within the phuslu package aim to enhance error handling for type assertions in the With method. This modification introduces a safety check using the comma-ok idiom to verify that the keys are of the expected string type, thereby preventing potential runtime panics from type assertion errors and ensuring more robust and reliable logging functionality.

Changes

File	Change Summary
mod/log/pkg/phuslu/phuslu.go	Improved the With method of Logger to handle type assertion errors safely by verifying key types using the comma-ok idiom.

Poem

Whiskers twitch with coder's grace,
Errors caught, no need to chase.
Logs now safe, no panic's stir,
Keys checked well, a coder's purr.
Changes whisper soft and bright,
Code runs smooth, day and night.
🐰✨

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 6385030 and 9ca00d8.

Files selected for processing (1)

• mod/log/pkg/phuslu/phuslu.go (1 hunks)

Additional comments not posted (3)

mod/log/pkg/phuslu/phuslu.go (3)

102-106: Type assertion correctly ensures keys are strings, enhancing error handling.

Consider adding a comment explaining why this check is necessary, as it helps maintainers understand the need for this type safety feature.

---

Line range hint 98-106: Deep copy of the context map with preallocated size is a performance-conscious practice.

This ensures that the new logger instance does not affect the original logger's state, which is crucial for concurrent use cases.

---

102-106: Loop correctly handles context addition by skipping non-string keys, aligning with the PR's safety enhancement objectives.

This change effectively prevents runtime errors due to incorrect key types, enhancing the robustness of the logger.