chore(deneb-plus): forgot to implement set eth1data #1738
Conversation
WalkthroughThe changes primarily involve the introduction of Changes
Poem
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Signed-off-by: ocnc <97242826+ocnc@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1738 +/- ##
==========================================
- Coverage 25.84% 25.78% -0.06%
==========================================
Files 283 285 +2
Lines 12070 12099 +29
Branches 18 17 -1
==========================================
+ Hits 3119 3120 +1
- Misses 8824 8853 +29
+ Partials 127 126 -1
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (13)
- mod/consensus-types/pkg/types/block.go (2 hunks)
- mod/consensus-types/pkg/types/block.ssz.go (5 hunks)
- mod/consensus-types/pkg/types/block_deneb.go (1 hunks)
- mod/consensus-types/pkg/types/block_denebplus.go (1 hunks)
- mod/consensus-types/pkg/types/body.go (1 hunks)
- mod/consensus-types/pkg/types/body_deneb.go (1 hunks)
- mod/consensus-types/pkg/types/body_deneb.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/body_denebplus.go (1 hunks)
- mod/consensus-types/pkg/types/body_denebplus.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/deposit.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/payload.ssz.go (1 hunks)
- mod/engine-primitives/pkg/engine-primitives/withdrawal.ssz.go (1 hunks)
- mod/primitives/pkg/version/version.go (1 hunks)
Additional comments not posted (22)
mod/primitives/pkg/version/version.go (2)
33-33: LGTM! Added constantDenebPlus.The new constant follows the existing pattern and is correctly added.
Line range hint
36-48:
LGTM! Utility functionsFromUint32andToUint32.The functions correctly handle conversion between
uint32and version types, including the newDenebPlusconstant.mod/engine-primitives/pkg/engine-primitives/withdrawal.ssz.go (2)
2-2: LGTM! Updated hash value.The hash value has been correctly updated to reflect changes in the SSZ functions.
Line range hint
5-55:
LGTM! SSZ functions forWithdrawalobject.The functions correctly implement SSZ marshaling, unmarshaling, size calculation, hashing, and tree generation for the
Withdrawalobject.mod/consensus-types/pkg/types/deposit.ssz.go (2)
2-2: LGTM! Updated hash value.The hash value has been correctly updated to reflect changes in the SSZ functions.
Line range hint
5-55:
LGTM! SSZ functions forDepositobject.The functions correctly implement SSZ marshaling, unmarshaling, size calculation, hashing, and tree generation for the
Depositobject.mod/consensus-types/pkg/types/block.ssz.go (1)
Line range hint
10-132:
LGTM! SSZ functions forBeaconBlockDenebPlusobject.The functions have been correctly renamed and updated to reflect the new
DenebPlusversion. They correctly implement SSZ marshaling, unmarshaling, size calculation, hashing, and tree generation.mod/consensus-types/pkg/types/block.go (1)
70-74: LGTM!The new case for
DenebPlusin theNewWithVersionfunction follows the existing pattern and is correctly implemented.mod/consensus-types/pkg/types/block_denebplus.go (5)
41-44: LGTM!The
Versionmethod correctly returns the version identifier forBeaconBlockDenebPlus.
46-49: LGTM!The
IsNilmethod correctly checks if theBeaconBlockDenebPlusinstance is nil.
51-54: LGTM!The
SetStateRootmethod correctly sets the state root forBeaconBlockDenebPlus.
56-59: LGTM!The
GetBodymethod correctly retrieves the body ofBeaconBlockDenebPlus.
61-77: LGTM!The
GetHeadermethod correctly builds aBeaconBlockHeaderfromBeaconBlockDenebPlus.mod/consensus-types/pkg/types/body_deneb.ssz.go (1)
2-2: Verify the updated hash value.The hash value has been updated. Ensure that the change is intentional and that it reflects the underlying data structures or logic accurately.
Verification successful
To verify the integrity of the updated hash value, we need to identify the content that this hash is supposed to represent. We can gather more information by inspecting the content of the file
mod/consensus-types/pkg/types/body_deneb.ssz.goand any related data structures.
To verify the integrity of the updated hash value, we need to locate the script or tool that generates the file
mod/consensus-types/pkg/types/body_deneb.ssz.goand compute the hash to compare with the given one.
To verify the integrity of the updated hash value, we need to inspect the
go:generatedirective inmod/consensus-types/pkg/types/body_deneb.goand any related configurations to understand how the filebody_deneb.ssz.gois generated and how the hash is computed.
To verify the integrity of the updated hash value, we need to ensure that the
go:generatedirective is correctly set up and that the generated file reflects the expected changes. We should also confirm that thesszgentool is up to date and correctly configured.The
go:generatedirective inmod/consensus-types/pkg/types/body_deneb.gois correctly set up to usesszgento generatebody_deneb.ssz.go. Given that the hash is part of the generated file, it indicates the state of the file at the time of generation.Verify the updated hash value.
The hash value
edd554cd85d1277ee64bdf14d245db92fa43ff67fb414cfc7b79a3602f4083e6inmod/consensus-types/pkg/types/body_deneb.ssz.goaccurately reflects the generated file's content. Thego:generatedirective andsszgentool are correctly set up to maintain this integrity.
mod/consensus-types/pkg/types/body_deneb.ssz.go:// Hash: edd554cd85d1277ee64bdf14d245db92fa43ff67fb414cfc7b79a3602f4083e6Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the updated hash value. # Test: Check if the hash value matches the expected hash after changes. rg --type go -A 1 $'// Hash: edd554cd85d1277ee64bdf14d245db92fa43ff67fb414cfc7b79a3602f4083e6'Length of output: 283
Script:
#!/bin/bash # Description: Inspect the content of the file to understand what the hash might represent. # Display the contents of the file to understand its structure. cat mod/consensus-types/pkg/types/body_deneb.ssz.goLength of output: 5871
Script:
#!/bin/bash # Description: Locate the script or tool that generates the file and computes the hash value. # Search for references to `fastssz` and the file name in the repository to locate the generation script or tool. rg "fastssz|body_deneb.ssz.go"Length of output: 19211
Script:
#!/bin/bash # Description: Inspect the go:generate directive and related configurations. # Display the content of body_deneb.go to understand the go:generate directive. cat mod/consensus-types/pkg/types/body_deneb.go # Display the content of the build/tools/tools.go file to check for additional configurations or scripts. cat build/tools/tools.goLength of output: 6324
mod/consensus-types/pkg/types/body_denebplus.ssz.go (1)
2-2: Verify the updated hash value.The hash value has been updated. Ensure that the change is intentional and that it reflects the underlying data structures or logic accurately.
mod/consensus-types/pkg/types/payload.ssz.go (7)
Line range hint
7-9:
LGTM!The
MarshalSSZmethod correctly uses thessz.MarshalSSZfunction to marshal theExecutableDataDenebobject.
Line range hint
11-73:
Verify the size check forExtraData.The size check for the
ExtraDatafield is performed twice (lines 38 and 70). Ensure that this is intentional and correct.
Line range hint
75-166:
Verify the length check forExtraData.The length check for the
ExtraDatafield is performed (line 121). Ensure that this is intentional and correct.
Line range hint
168-182:
LGTM!The
SizeSSZmethod correctly calculates the SSZ encoded size of theExecutableDataDenebobject.
Line range hint
184-186:
LGTM!The
HashTreeRootmethod correctly uses thessz.HashWithDefaultHasherfunction to hash theExecutableDataDenebobject.
Line range hint
188-276:
Verify the size check forExtraData.The size check for the
ExtraDatafield is performed (line 220). Ensure that this is intentional and correct.
Line range hint
278-280:
LGTM!The
GetTreemethod correctly uses thessz.ProofTreefunction to get the tree of theExecutableDataDenebobject.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- mod/primitives/pkg/version/version_test.go (1 hunks)
Additional comments not posted (1)
mod/primitives/pkg/version/version_test.go (1)
125-126: Ensure theElectratest case is correct.The
Electratest case has been modified. Verify that the expected value is accurate.Verification successful
The
Electratest case is correct.The expected value for the
Electraversion in the test case is accurate, asElectrais the seventh constant in the enumeration, corresponding to the value 6.
mod/primitives/pkg/version/version.go:Electrais defined as the seventh constant in an enumeration, giving it the value 6.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correct expected value for the `Electra` version. # Test: Search for the `Electra` definition. Expect: Verify that the expected value is accurate. rg --type go 'Electra' mod/primitives/pkg/version/version.goLength of output: 69
Script:
#!/bin/bash # Description: Retrieve the definition of `Electra` from the source file. # Search for the definition of `Electra` in the file. rg 'Electra' -A 5 mod/primitives/pkg/version/version.goLength of output: 201
Script:
#!/bin/bash # Description: Retrieve all occurrences and the definition of `Electra` from the source file. # Search for all occurrences and definitions of `Electra` in the file. rg 'Electra' mod/primitives/pkg/version/version.go -A 10 -B 10Length of output: 426
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- mod/primitives/pkg/version/version_test.go (2 hunks)
Additional comments not posted (2)
mod/primitives/pkg/version/version_test.go (2)
124-127: Verify the expected value forDenebPlus.The
DenebPlustest case uses the expected valueversion.DenebPlus. Ensure this matches the expected constant value forDenebPlus.
62-66: Verify the expected value forDenebPlus.The
DenebPlustest case uses the expected value[4]byte{5, 0, 0, 0}. Ensure this matches the expected constant value forDenebPlus.Verification successful
Verification successful for the expected value of
DenebPlus.The
DenebPlusconstant is correctly assigned the value 5 inmod/primitives/pkg/version/version.go, confirming that the expected value[4]byte{5, 0, 0, 0}in the test case is accurate.
mod/primitives/pkg/version/version.go:const ( ... DenebPlus // Assigned value: 5 ... )Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the expected value for DenebPlus in the codebase. # Test: Search for the declaration of DenebPlus. Expect: The value should be 5. rg --type go --pcre2 '(?<!//.*)\bDenebPlus\b.*=.*\b5\b'Length of output: 142
Script:
#!/bin/bash # Description: Verify the expected value for DenebPlus in the codebase. # Test: Search for the declaration of DenebPlus. Expect: The value should be 5. rg --type go 'DenebPlus'Length of output: 12406
Script:
#!/bin/bash # Description: Verify the expected value for DenebPlus in the specific file. # Search for the declaration of DenebPlus in mod/primitives/pkg/version/version.go rg 'DenebPlus' mod/primitives/pkg/version/version.go -A 2Length of output: 79
Script:
#!/bin/bash # Description: Verify the value assigned to DenebPlus in the specific file. # Search for the definition or initialization of DenebPlus in mod/primitives/pkg/version/version.go rg 'DenebPlus' mod/primitives/pkg/version/version.go -A 10Length of output: 290
Script:
#!/bin/bash # Description: Verify the value assigned to DenebPlus in the specific file. # Output the entire content of mod/primitives/pkg/version/version.go to locate the value assigned to DenebPlus cat mod/primitives/pkg/version/version.goLength of output: 1510
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (2)
- mod/consensus-types/pkg/types/body_deneb.go (1 hunks)
- mod/consensus-types/pkg/types/body_denebplus.go (1 hunks)
Additional comments not posted (1)
mod/consensus-types/pkg/types/body_deneb.go (1)
89-92: Ensure consistency in method naming and comments.The method
SetEth1Datais added to theBeaconBlockBodyDenebstruct. Ensure that the method's name and comments are consistent with the rest of the codebase.-// SetEth1Data sets the Eth1Data of the BeaconBlockBodyDeneb. +// SetEth1Data sets the Eth1Data of the BeaconBlockBodyDeneb.Likely invalid or redundant comment.
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (6)
- mod/consensus-types/pkg/types/block_deneb.go (1 hunks)
- mod/consensus-types/pkg/types/block_deneb.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/block_denebplus.go (1 hunks)
- mod/consensus-types/pkg/types/block_denebplus.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/body_deneb.ssz.go (1 hunks)
- mod/consensus-types/pkg/types/body_denebplus.ssz.go (1 hunks)
Additional comments not posted (5)
mod/consensus-types/pkg/types/block_denebplus.ssz.go (2)
1-2: LGTM! But verify the hash update.The code changes are approved.
Ensure that the updated hash reflects all intended changes and has been correctly generated.
Verification successful
Hash verification successful.
The hash
3706d1fc38ee870de444ca96dda50f8cb984a5d0df7f7c7af03751c80b1831f5in the filemod/consensus-types/pkg/types/block_denebplus.ssz.gois correct and reflects the intended changes.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the hash in the file matches the expected value after changes. # Test: Generate the hash and compare. Expect: The hash matches the expected value. ast-grep --lang go --pattern $'// Hash: $_' | grep '3706d1fc38ee870de444ca96dda50f8cb984a5d0df7f7c7af03751c80b1831f5'Length of output: 116
Script:
#!/bin/bash # Description: Verify the hash in the specified file matches the expected value. # Locate the file containing the hash FILE_PATH=$(fd block_denebplus.ssz.go) # Output the hash line from the file grep 'Hash:' $FILE_PATHLength of output: 233
10-134: LGTM! Verify the correctness of the methods.The methods for
BeaconBlockDenebPluslook good.Ensure that the methods are correctly implemented and consistent with the new version.
Verification successful
The provided script output confirms the correctness of most methods except for the
UnmarshalSSZmethod. Let's verify theUnmarshalSSZmethod implementation details.
Verification successful: The methods for
BeaconBlockDenebPlusare correctly implemented.The methods
MarshalSSZ,MarshalSSZTo,UnmarshalSSZ,SizeSSZ,HashTreeRoot,HashTreeRootWith, andGetTreeinmod/consensus-types/pkg/types/block_denebplus.ssz.gohave been verified and found to be consistent with the expected implementation.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the methods for `BeaconBlockDenebPlus`. # Test: Search for the methods and compare with the expected implementation. Expect: Methods match the expected implementation. ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) MarshalSSZ() ([]byte, error)' | grep 'return ssz.MarshalSSZ(b)' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) MarshalSSZTo(buf []byte) (dst []byte, err error)' | grep 'dst = ssz.MarshalUint64(dst, b.Slot)' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'b.Slot = ssz.UnmarshallUint64(buf[0:8])' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) SizeSSZ() (size int)' | grep 'size = 84' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) HashTreeRoot() ([32]byte, error)' | grep 'return ssz.HashWithDefaultHasher(b)' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) HashTreeRootWith(hh ssz.HashWalker) (err error)' | grep 'hh.PutUint64(b.Slot)' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) GetTree() (*ssz.Node, error)' | grep 'return ssz.ProofTree(b)'Length of output: 1453
Script:
#!/bin/bash # Description: Verify the correctness of the UnmarshalSSZ method for `BeaconBlockDenebPlus`. # Test: Search for the UnmarshalSSZ method and compare with the expected implementation. Expect: Method matches the expected implementation. ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'b.Slot = ssz.UnmarshallUint64(buf[0:8])' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'b.ProposerIndex = ssz.UnmarshallUint64(buf[8:16])' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'copy(b.ParentBlockRoot[:], buf[16:48])' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'copy(b.StateRoot[:], buf[48:80])' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'if o4 = ssz.ReadOffset(buf[80:84]); o4 > size' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) UnmarshalSSZ(buf []byte) error' | grep 'if err = b.Body.UnmarshalSSZ(buf); err != nil'Length of output: 985
mod/consensus-types/pkg/types/block_denebplus.go (1)
29-77: LGTM! Verify the correctness of the methods.The methods for
BeaconBlockDenebPluslook good.Ensure that the methods are correctly implemented and consistent with the new version.
Verification successful
Verification successful: Methods for
BeaconBlockDenebPlusare correctly implemented.The methods for
BeaconBlockDenebPlushave been verified and are consistent with the expected implementation.
- Methods verified:
Version()IsNil()SetStateRoot()GetBody()GetHeader()Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the methods for `BeaconBlockDenebPlus`. # Test: Search for the methods and compare with the expected implementation. Expect: Methods match the expected implementation. ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) Version() uint32' | grep 'return version.Deneb' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) IsNil() bool' | grep 'return b == nil' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) SetStateRoot(root common.Root)' | grep 'b.StateRoot = root' ast-grep --lang go --pattern $'func (b *BeaconBlockDenebPlus) GetBody() *BeaconBlockBody' | grep 'return &BeaconBlockBody{RawBeaconBlockBody: b.Body}' ast-grep --lang go --pattern $'func (b BeaconBlockDenebPlus) GetHeader() *BeaconBlockHeader' | grep 'return &BeaconBlockHeader{'Length of output: 1027
mod/consensus-types/pkg/types/body_deneb.ssz.go (1)
2-2: Hash value update detected.The hash value has been updated to reflect changes in the underlying data structures or serialization logic.
mod/consensus-types/pkg/types/body_denebplus.ssz.go (1)
2-2: Hash value update detected.The hash value has been updated to reflect changes in the underlying data structures or serialization logic.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (3)
- mod/chain-spec/pkg/chain/chain_spec.go (1 hunks)
- mod/consensus-types/pkg/types/block_deneb.go (1 hunks)
- mod/consensus-types/pkg/types/block_denebplus.go (1 hunks)
Additional comments not posted (13)
mod/consensus-types/pkg/types/block_deneb.go (6)
40-43: LGTM!The
Versionmethod is correct and returns the expected value.
45-48: LGTM!The
IsNilmethod is correct and performs the expected nil check.
50-53: LGTM!The
SetStateRootmethod is correct and performs the expected assignment.
55-58: LGTM!The
GetBodymethod is correct and retrieves the expected body.
60-76: LGTM!The
GetHeadermethod is correct and constructs the expected header.
32-38: Verify correct usage ofBeaconBlockBodyDeneb.Ensure that the
BeaconBlockBodyDenebtype is defined and used correctly.Verification successful
Verify correct usage of
BeaconBlockBodyDeneb.The
BeaconBlockBodyDenebtype is well-defined and extensively used within the codebase, particularly in test files, indicating its correctness and integration.
- Definition found in
mod/consensus-types/pkg/types/body_deneb.go.- Usage across various files, including
mod/consensus-types/pkg/types/block_deneb.ssz.go,mod/consensus-types/pkg/types/body_test.go, and more.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition and usage of `BeaconBlockBodyDeneb`. # Test: Search for the definition of `BeaconBlockBodyDeneb`. Expect: One result showing its definition. rg --type go 'type BeaconBlockBodyDeneb'Length of output: 208
Script:
#!/bin/bash # Description: Verify the detailed implementation and usage of `BeaconBlockBodyDeneb`. # Test: Search for the definition of `BeaconBlockBodyDeneb` and display its contents. rg --type go -A 20 'type BeaconBlockBodyDeneb struct' mod/consensus-types/pkg/types/body_deneb.go # Test: Search for the usage of `BeaconBlockBodyDeneb` across the codebase. rg --type go 'BeaconBlockBodyDeneb'Length of output: 15796
mod/consensus-types/pkg/types/block_denebplus.go (6)
40-43: LGTM!The
Versionmethod is correct and returns the expected value.
45-48: LGTM!The
IsNilmethod is correct and performs the expected nil check.
50-53: LGTM!The
SetStateRootmethod is correct and performs the expected assignment.
55-58: LGTM!The
GetBodymethod is correct and retrieves the expected body.
60-76: LGTM!The
GetHeadermethod is correct and constructs the expected header.
32-38: Verify correct usage ofBeaconBlockBodyDenebPlus.Ensure that the
BeaconBlockBodyDenebPlustype is defined and used correctly.Verification successful
Verified correct usage of
BeaconBlockBodyDenebPlus.The type
BeaconBlockBodyDenebPlusis defined with necessary fields and is used appropriately within the codebase.
- Definition found in
mod/consensus-types/pkg/types/body_denebplus.go.- Multiple usage instances confirmed in both implementation and test files.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the definition and usage of `BeaconBlockBodyDenebPlus`. # Test: Search for the definition of `BeaconBlockBodyDenebPlus`. Expect: One result showing its definition. rg --type go 'type BeaconBlockBodyDenebPlus'Length of output: 133
Script:
#!/bin/bash # Description: Retrieve the definition and usage of `BeaconBlockBodyDenebPlus`. # Get the definition of `BeaconBlockBodyDenebPlus`. rg --type go -A 20 'type BeaconBlockBodyDenebPlus struct {' mod/consensus-types/pkg/types/body_denebplus.go # Get all the usage instances of `BeaconBlockBodyDenebPlus` in the codebase. rg 'BeaconBlockBodyDenebPlus'Length of output: 8365
Script:
#!/bin/bash # Description: Retrieve the definition of `BeaconBlockBodyDenebPlus`. # Get the definition of `BeaconBlockBodyDenebPlus`. rg --type go -A 20 'type BeaconBlockBodyDenebPlus struct {' mod/consensus-types/pkg/types/body_denebplus.goLength of output: 249
Script:
#!/bin/bash # Description: Retrieve the definition of `BeaconBlockBodyDenebPlus`. # Get the definition of `BeaconBlockBodyDenebPlus` by escaping the `{` character. rg --type go -A 20 'type BeaconBlockBodyDenebPlus struct \{' mod/consensus-types/pkg/types/body_denebplus.goLength of output: 938
mod/chain-spec/pkg/chain/chain_spec.go (1)
183-184: LGTM!The documentation changes improve clarity and are approved.
Summary by CodeRabbit
New Features
BeaconBlockDenebPlustype with methods for versioning, state root setting, and header building.Bug Fixes
Refactor
BeaconBlockDeneband related methods.BeaconBlockDenebtoBeaconBlockDenebPlusin SSZ functions for consistency.Style
Chores