Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(consensus, beacon): let consensus tell SuggestedNextPayloadTimestamp #2101

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

abi87
Copy link
Collaborator

@abi87 abi87 commented Oct 25, 2024

We let a consensus block indicate the proposed timestamp for the next payload, which:

  • Is built to be strictly monotonic across all ABCI requests (Propose/Prepare/FinalizeBlock)
  • Is used to bound current payload timestamp, to avoid dangerous run-aways

@abi87 abi87 self-assigned this Oct 25, 2024
Copy link
Contributor

coderabbitai bot commented Oct 25, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 52 lines in your changes missing coverage. Please review.

Project coverage is 23.37%. Comparing base (cbc89a4) to head (fb80d64).
Report is 1 commits behind head on consensus_decorated_events.

Files with missing lines Patch % Lines
...nsus/pkg/cometbft/service/middleware/middleware.go 0.00% 12 Missing ⚠️
mod/consensus/pkg/types/slot_data.go 0.00% 6 Missing ⚠️
mod/beacon/blockchain/receive.go 0.00% 5 Missing ⚠️
mod/beacon/validator/block_builder.go 0.00% 5 Missing ⚠️
mod/consensus/pkg/cometbft/service/abci.go 0.00% 5 Missing ⚠️
mod/beacon/blockchain/payload.go 0.00% 4 Missing ⚠️
mod/consensus/pkg/types/consensus_block.go 0.00% 4 Missing ⚠️
...ate-transition/pkg/core/state_processor_payload.go 0.00% 4 Missing ⚠️
.../consensus/pkg/cometbft/service/middleware/abci.go 0.00% 2 Missing ⚠️
mod/primitives/pkg/transition/context.go 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@                      Coverage Diff                       @@
##           consensus_decorated_events    #2101      +/-   ##
==============================================================
- Coverage                       23.39%   23.37%   -0.03%     
==============================================================
  Files                             357      357              
  Lines                           16111    16125      +14     
  Branches                           12       12              
==============================================================
  Hits                             3769     3769              
- Misses                          12172    12186      +14     
  Partials                          170      170              
Files with missing lines Coverage Δ
mod/beacon/blockchain/execution_engine.go 0.00% <0.00%> (ø)
mod/beacon/blockchain/process.go 0.00% <0.00%> (ø)
mod/node-core/pkg/components/middleware.go 0.00% <0.00%> (ø)
.../consensus/pkg/cometbft/service/middleware/abci.go 0.00% <0.00%> (ø)
mod/primitives/pkg/transition/context.go 0.00% <0.00%> (ø)
mod/beacon/blockchain/payload.go 0.00% <0.00%> (ø)
mod/consensus/pkg/types/consensus_block.go 0.00% <0.00%> (ø)
...ate-transition/pkg/core/state_processor_payload.go 0.00% <0.00%> (ø)
mod/beacon/blockchain/receive.go 0.00% <0.00%> (ø)
mod/beacon/validator/block_builder.go 0.00% <0.00%> (ø)
... and 3 more

@abi87 abi87 changed the title wip: renaming consensus time to nextPayloadTimestamp fix(consensus, beacon): let consensus tell SuggestedNextPayloadTimestamp Oct 25, 2024
@abi87 abi87 marked this pull request as ready for review October 25, 2024 19:58
@abi87 abi87 merged commit 699df26 into consensus_decorated_events Oct 25, 2024
3 checks passed
@abi87 abi87 deleted the fix-execution-payload branch October 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant