This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the contextual toolbar to cover selections that are about to be edited.
In case there is a selection, move toolbar on top of it and align with
start of selection. Else move it on top of current position, center it and move
it slightly to the right.
Hope you like it!
In the future it would probably be best to also test for the case when the toolbar
will popup outside the visible area, like for text on the top of the client window,
and reposition it to a visible position.
A general question: I was building hallo.js with these changes before committing.
Shall I always do this or rather not check in new builds?