This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Improved contextual toolbar positioning #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also added 2 plugins here: hallohtml and hallo-image-insert-edit. Hallo html is a simple plugin to edit the html source of the editable html element. hallo-image-insert-edit allows to insert images by url and to edit existing image's basic properties. There is also an option to supply ones own image browser to select image urls. Further, I did some minor fixes and added some conveniences. Would be great if you could merge this. I use the new plugins already in a gem for rails I recently created: https://github.com/ncri/hallo_rails |
bergie
added a commit
that referenced
this pull request
Nov 15, 2012
Improved contextual toolbar positioning
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #120
The default position for the toolbar is now again below the selected text or caret.
This can be changed to above the selected text or caret by setting the hallo option