Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in getNotifications methos #189

Open
diogocoutinho opened this issue Apr 17, 2024 · 0 comments
Open

Bug in getNotifications methos #189

diogocoutinho opened this issue Apr 17, 2024 · 0 comments

Comments

@diogocoutinho
Copy link

The getNotifications with a bug of write.

Error:

In the line 430 of OneSignalClient:

        if($offset) {
            $endpoint.="&offset=".$$offset;
        }

Here seems a double "$" and caused a error when provide a offset by user

Solution:

Just remove a "$"

        if($offset) {
            $endpoint.="&offset=".$offset;
        }

I will a PR to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant