Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility feature only #10

Merged
merged 5 commits into from
Feb 3, 2017
Merged

Visibility feature only #10

merged 5 commits into from
Feb 3, 2017

Conversation

jitsmaster
Copy link
Contributor

This pull request include only the visibility feature. The animate and layoutEnd features will be included in next pull request

bertrandg and others added 3 commits January 19, 2017 10:27
@bertrandg @jitsmaster
v0.1.16 only update build process
295af20
@jitsmaster
Introduced visibility property on split-area and split-gutter.
c7c92b9 
The purpose of visibility for split areas if to establish persiting router
outlets within each split area.

Since new router v3. Router outlet within conditional split areas can't be
consistently relied on.

Extensive testing were done, to make sure this change doesn't impact how the
split areas' conditional rendering, just add ability to toggle areas
on/off visually.
@jitsmaster
Revert tsconfig back to aot build setup
e539e79
@bertrandg
Copy link
Contributor

Cool thanks.

Just discovered an other bug to fix:
bug_event_sizes

@jitsmaster
Fix issue of split gutter remains when the last area is hidden.
a3d5ab8 
This fixes the general issue of area are hidden from the end.
@jitsmaster
Copy link
Contributor Author

The visibility for end areas fix just checked in. Could you give me a description of the new bug?

@bertrandg
Copy link
Contributor

dragStart, dragProgress & dragEnd should send an array containing ordered visible areas percentage size (all values additionned equal 100).

Here areaA is not visible but value sended.

@jitsmaster
Copy link
Contributor Author

Got it. Working on this

@bertrandg
Copy link
Contributor

cool :)

@jitsmaster
Copy link
Contributor Author

Done

@bertrandg bertrandg merged commit 1617234 into angular-split:master Feb 3, 2017
@jitsmaster
Copy link
Contributor Author

Thank you Sir.
I will look into the shadow dom issue for split component css. Then create second pull request

@bertrandg
Copy link
Contributor

:)
I'm gonna publish 0.1.17 on NPM tonight and add it to website.

@jitsmaster
Copy link
Contributor Author

jitsmaster commented Feb 3, 2017 via email

@angular-split angular-split locked and limited conversation to collaborators Feb 18, 2021
@Jefiozie
Copy link
Member

@all-contributors please add @jitsmaster for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jitsmaster @bertrandg @Jefiozie