-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OnlineRequestProcessor V2 Megathread #204
Comments
Other things I have been thinking about:
These are all variables to have control over and it would be good to have nice clean interfaces and abstractions, instead of 100s of arguments to the LLM class. Let's break down these variables by category. The abstraction of curator is to create a dataset based on the input dataset, mapping, and relevant generation config. The user doesn't really care about how these get turned into requests and how those get turned into responses. They just want that dataset created accurately and as quickly as possible. Labeling ones that don't exist in bold LLM map definition (these should change the hash)
curator configuration (things users shouldn't have to care / know about - these shouldn't change the hash)
generation configuration (arguments that go to API - these should also change the hash)
More on retry logic: which types of exceptions to retry on and the behavior like exponential, etc. LiteLLM has exception classes we can use that exhibit exceptions with the request --> response part. For the raw http processor (openai online, maybe can read it into OpenAI / litellm objects to get same exceptions there). But there are also Curator exception classes to create (e.g. which finish reasons are ok). More thinking in #261. It would be good to have the curator exceptions also be used when resubmitting batches as discussed in #226. More on rate limit logic: allowing for automatic rate limit detection as discussed in #233. also allowing for other types of rate limits like connection number as discussed in #253 |
Capturing the action items after #141 comments.
Features:
has_capacity
using hidden_params #207The text was updated successfully, but these errors were encountered: