Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a minimal version of Python to work with #13

Open
arxitim opened this issue Nov 11, 2022 · 0 comments
Open

Set a minimal version of Python to work with #13

arxitim opened this issue Nov 11, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@arxitim
Copy link

arxitim commented Nov 11, 2022

Good day!I really liked your library and wanted to add it to my CI.
But it completely slipped my mind that I'm working with a pretty old version of Python3.5

It was easy to install the package and I already started adding it to my master, but after that no CI was successful.
This is because this package uses some features of newer versions of Python that aren't available in 3.5, like types in variable declaration.
Unfortunately, I didn't realize this right away and wasted a lot of time researching it.

I suggest adding the python_requires directive to setup.py/setup.cfg so that I and other users of older versions of Python run into the problem already at the installation stage of the package

I understand that this is stated in both the project badges and the description, but sometimes we all make mistakes, and this clarification could save a little time)

@arxitim arxitim added the enhancement New feature or request label Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant