Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Tracker fails to display all 4 moves used by enemy Pokémon in battle #498

Closed
UTDZac opened this issue Dec 16, 2024 · 1 comment · Fixed by #500
Closed

[Bug]: Tracker fails to display all 4 moves used by enemy Pokémon in battle #498

UTDZac opened this issue Dec 16, 2024 · 1 comment · Fixed by #500
Assignees
Labels
Bug Something isn't working Fixed/Added in Dev Bugs fixed / Features added in dev, but not in main/release yet. Move Tracking Bugs/Features relating to move tracking
Milestone

Comments

@UTDZac
Copy link
Collaborator

UTDZac commented Dec 16, 2024

Describe the bug

This is a follow-up to this issue: #202

Just reading through it again has given me an idea for how to solve the more common case here: where all 4 moves do get used in battle and those should be the 4 moves displayed.

The solution is to just track the moves used for the Pokémon (plural) in the current battle, like we track many battle related things. If all 4 moves are known for a given Pokémon, the Tracker just displays those; otherwise is falls back to using the original implementation.

Seems easy enough to code while also avoiding the legacy code logic I've been really trying to avoid changing

Steps to Reproduce

Example Scenario

image image

In this case, the lv.32 Shedinja used moves: Spikes, Sweet Scent, Aromatherapy, and Torment, but the Tracker is displaying a non-helpful old move.

What tracker version are you using?

v8.9.0

What operating system are you using?

Windows

What emulator(s) are you seeing the problem on?

Bizhawk 2.9

Relevant log output

No response

Additional Information

No response

@UTDZac UTDZac added the Bug Something isn't working label Dec 16, 2024
@UTDZac UTDZac self-assigned this Dec 16, 2024
@UTDZac UTDZac linked a pull request Dec 22, 2024 that will close this issue
@UTDZac UTDZac added the Fixed/Added in Dev Bugs fixed / Features added in dev, but not in main/release yet. label Jan 6, 2025
@Fellshadow Fellshadow added this to the 9.0.0 milestone Jan 8, 2025
@Fellshadow Fellshadow added the Move Tracking Bugs/Features relating to move tracking label Jan 8, 2025
@UTDZac
Copy link
Collaborator Author

UTDZac commented Jan 8, 2025

Completed in v9.0.0

@UTDZac UTDZac closed this as completed Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fixed/Added in Dev Bugs fixed / Features added in dev, but not in main/release yet. Move Tracking Bugs/Features relating to move tracking
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants