-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to storybook 7 #565
Conversation
cc5c520
to
3c5567a
Compare
3c5567a
to
50b85a1
Compare
@bestguy @gary-mycase any chance you might be able to take a look at this one? |
Sure, I'll take a look to review/merge this weekend, thanks for your patience. |
Thanks! |
@kefahi can you share what command you ran and what you expected to happen? |
I think this was my bad. The storybook binary itself was missing, hence running Can be found on this git branch. The above branch is based on the Svelte4 fixes branch that was prepared earlier. I'm good now with both Svelte4 and Storybook7 without any known issues (including passing CI checks). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @benmccann , this is great, thanks.
Looks like one change is needed in my testing.
"@storybook/blocks": "^7.2.1", | ||
"@storybook/svelte": "^7.2.1", | ||
"@storybook/svelte-webpack5": "^7.2.1", | ||
"@storybook/testing-library": "^0.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using node 20.8.1, I also needed to add:
"@storybook/theming": "^7.4.6",
otherwise got an error running npm start
after npm install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I can easily do a follow on PR to add that missing dep after merge.
Fixed with #576 |
No description provided.