Show unused environments and allow matching nodes to other environments

.rubocop_todo.yml

@@ -41,7 +41,6 @@ Layout/EmptyLineAfterGuardClause:
     - 'app/models/hiera_data/config.rb'
     - 'app/models/hiera_data/hierarchy.rb'
     - 'app/models/hiera_data/yaml_file.rb'
-    - 'test/support/fake_puppet_db.rb'
 
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
@@ -66,14 +65,6 @@ Layout/EmptyLinesAroundAccessModifier:
     - 'app/controllers/users_controller.rb'
     - 'test/models/hiera_data/yaml_file_test.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Exclude:
-    - 'app/models/hiera_data.rb'
-
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
@@ -116,7 +107,6 @@ Layout/HashAlignment:
   Exclude:
     - 'app/models/user.rb'
     - 'test/models/key_test.rb'
-    - 'test/models/node_test.rb'
 
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
@@ -158,13 +148,6 @@ Layout/MultilineMethodCallIndentation:
     - 'app/models/hiera_data/data_file.rb'
     - 'app/models/hiera_data/hierarchy.rb'
     - 'app/models/key.rb'
-    - 'test/support/fake_puppet_db.rb'
-
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Layout/SpaceAfterComma:
-  Exclude:
-    - 'test/support/fake_puppet_db.rb'
 
 # Offense count: 13
 # This cop supports safe auto-correction (--auto-correct).
@@ -176,7 +159,6 @@ Layout/SpaceAroundOperators:
     - 'test/models/hiera_data/data_file_test.rb'
     - 'test/models/hiera_data/yaml_file_test.rb'
     - 'test/models/hiera_data_test.rb'
-    - 'test/models/node_test.rb'
 
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
@@ -198,8 +180,6 @@ Layout/SpaceInsideHashLiteralBraces:
     - 'test/models/hiera_data/yaml_file_test.rb'
     - 'test/models/hiera_data_test.rb'
     - 'test/models/key_test.rb'
-    - 'test/models/node_test.rb'
-    - 'test/support/fake_puppet_db.rb'
 
 # Offense count: 1
 # This cop supports safe auto-correction (--auto-correct).
@@ -232,7 +212,6 @@ Lint/EmptyFile:
 Lint/ScriptPermission:
   Exclude:
     - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb'
-    - 'test/fixtures/files/puppet/generate_nodes.rb'
 
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
@@ -345,7 +324,6 @@ Security/YAMLLoad:
     - 'test/models/hiera_data/data_file_test.rb'
     - 'test/models/hiera_data/yaml_file_test.rb'
     - 'test/models/hiera_data_test.rb'
-    - 'test/support/fake_puppet_db.rb'
 
 # Offense count: 2
 # This cop supports safe auto-correction (--auto-correct).
@@ -357,7 +335,6 @@ Security/YAMLLoad:
 Style/BlockDelimiters:
   Exclude:
     - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb'
-    - 'test/fixtures/files/puppet/generate_nodes.rb'
 
 # Offense count: 16
 # This cop supports safe auto-correction (--auto-correct).
@@ -387,12 +364,6 @@ Style/CommandLiteral:
 Style/Documentation:
   Enabled: false
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-Style/FileWrite:
-  Exclude:
-    - 'test/fixtures/files/puppet/generate_nodes.rb'
-
 # Offense count: 1
 # Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
@@ -416,13 +387,6 @@ Style/GuardClause:
     - 'app/models/hiera_data/data_file.rb'
     - 'app/models/hiera_data/hierarchy.rb'
 
-# Offense count: 1
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: AllowSplatArgument.
-Style/HashConversion:
-  Exclude:
-    - 'test/support/fake_puppet_db.rb'
-
 # Offense count: 1
 # Configuration parameters: MinBranchesCount.
 Style/HashLikeCase:
@@ -499,7 +463,6 @@ Style/PreferredHashMethods:
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   Exclude:
-    - 'app/models/hiera_data.rb'
     - 'app/models/hiera_data/git_repo.rb'
 
 # Offense count: 1
@@ -593,7 +556,6 @@ Style/WordArray:
 Style/ZeroLengthPredicate:
   Exclude:
     - 'test/fixtures/files/puppet/environments/eyaml/generate_eyaml_entries.rb'
-    - 'test/fixtures/files/puppet/generate_nodes.rb'
 
 # Offense count: 23
 # This cop supports safe auto-correction (--auto-correct).

app/controllers/keys_controller.rb

@@ -7,15 +7,15 @@ class KeysController < ApplicationController
 
   def index
     authorize! :show, Key
-    @keys = Key.all_for(@node)
+    @keys = Key.all_for(@node, environment: @environment)
     @keys.select! { |k| current_user.may_access?(k) }
 
     add_breadcrumb @environment, environment_nodes_path(@environment)
     add_breadcrumb @node, environment_node_keys_path(@environment, @node)
   end
 
   def show
-    @keys = Key.all_for(@node)
+    @keys = Key.all_for(@node, environment: @environment)
     @keys.select! { |k| current_user.may_access?(k) }
     @key = Key.new(environment: @environment, name: params[:id])
     authorize! :show, @key
@@ -46,9 +46,9 @@ def destroy
   private
 
   def load_nodes
-    @nodes = Node.all(environment: @environment)
+    @nodes = Node.all
     @nodes.select! { |n| current_user.may_access?(n) }
-    @node = Node.new(hostname: params[:node_id], environment: @environment)
+    @node = Node.find(params[:node_id])
     authorize! :show, @node
   end
 end

app/controllers/nodes_controller.rb

@@ -6,7 +6,7 @@ class NodesController < ApplicationController
 
   def index
     authorize! :index, Node
-    @nodes = Node.all(environment: @environment)
+    @nodes = Node.all
     @nodes.select! { |n| current_user.may_access?(n) }
 
     add_breadcrumb @environment, environment_nodes_path(@environment)

app/javascript/controllers/select_navigation_controller.js

@@ -2,8 +2,14 @@ import { Controller } from "@hotwired/stimulus"
 import { Turbo } from "@hotwired/turbo-rails"
 
 export default class extends Controller {
+  connect() {
+    const selectedOption = this.element.options[this.element.selectedIndex]
+    this.initialUrl = selectedOption.dataset.url
+  }
+
   navigate() {
-    const selectedOption = this.element.options[this.element.selectedIndex];
-    Turbo.visit(selectedOption.dataset.url);
+    const selectedOption = this.element.options[this.element.selectedIndex]
+    const newUrl = selectedOption.dataset.url
+    if (newUrl != this.initialUrl) Turbo.visit(newUrl)
   }
 }

app/javascript/controllers/slim_select_controller.js

@@ -2,13 +2,40 @@ import { Controller } from "@hotwired/stimulus"
 import SlimSelect from "slim-select"
 
 export default class extends Controller {
+  static targets = ["dropdown"]
+
   connect() {
     this.select = new SlimSelect({
-      select: this.element,
-    });
+      select: this.dropdownTarget,
+    })
+    this.hideOptions()
   }
 
   disconnect() {
-    this.select.destroy();
+    this.select.destroy()
+  }
+
+  toggleFilter(event) {
+    if (event.target.checked) {
+      this.hideOptions()
+    } else {
+      this.showAllOptions()
+    }
+  }
+
+  hideOptions() {
+    this.select.setData(this.select.getData().map((o) => {
+      if (o["data"]["hidable"]) {
+        o["display"] = false
+      }
+      return o
+    }))
+  }
+
+  showAllOptions() {
+    this.select.setData(this.select.getData().map((o) => {
+      o["display"] = true
+      return o
+    }))
   }
 }

app/models/environment.rb

@@ -1,22 +1,27 @@
 class Environment < HieraModel
   attribute :name, :string
-
-  def self.all_names
-    PuppetDbClient.environments
-  end
+  attribute :in_use, :boolean, default: false
 
   def self.all
-    all_names.map { |e| new(name: e) }
+    environments_in_use = PuppetDbClient.environments
+    available_environments = HieraData.environments
+    unused_environments = available_environments - environments_in_use
+    environments_in_use.sort.map { |e| new(name: e, in_use: true) } +
+      unused_environments.sort.map { |e| new(name: e) }
   end
 
   def self.find(name)
-    new(name: name)
+    all.find { |e| e.name == name }
   end
 
   def hierarchies
     Hierarchy.all(self)
   end
 
+  def in_use?
+    in_use
+  end
+
   def ==(other)
     other.is_a?(Environment) && name == other.name
   end

app/models/hiera_data.rb

@@ -3,12 +3,24 @@ class HieraData
   class EnvironmentNotFound < StandardError; end
 
   attr_reader :environment
+
   delegate :hierarchies, to: :config
 
+  def self.environments
+    Pathname.new(config_dir)
+            .join("environments")
+            .glob("*/")
+            .map { |p| p.basename.to_s }
+  end
+
+  def self.config_dir
+    @config_dir ||= Rails.configuration.hdm.config_dir
+  end
+
   def initialize(environment)
     @environment = environment
 
-    raise EnvironmentNotFound.new("Environment '#{environment}' does not exist") unless PuppetDbClient.environments.include?(environment)
+    raise EnvironmentNotFound, "Environment '#{environment}' does not exist" unless self.class.environments.include?(environment)
   end
 
   def all_keys(facts)
@@ -125,12 +137,9 @@ def lookup_options(facts)
 
   private
 
-  def config_dir
-    @config_dir ||= Rails.configuration.hdm.config_dir
-  end
-
   def config
-    @config ||= Config.new(Pathname.new(config_dir).join("environments", environment))
+    @config ||= Config.new(Pathname.new(self.class.config_dir)
+      .join("environments", environment))
   end
 
   def find_hierarchy(name)

app/models/key.rb

@@ -2,9 +2,8 @@ class Key < HieraModel
   attribute :name, :string
   attribute :environment
 
-  def self.all_for(node)
+  def self.all_for(node, environment: node.environment)
     facts = node.facts
-    environment = node.environment
     keys = []
     HieraData.new(environment.name).all_keys(facts)
       .each do |name|

app/models/node.rb

@@ -3,14 +3,17 @@ class Node < HieraModel
   attribute :environment
   alias name hostname
 
-  def self.all_names(environment:)
-    PuppetDbClient.nodes(environment: environment)
+  def self.all(environment: nil)
+    node_records = PuppetDbClient.nodes(environment: environment&.name)
+    environments = Environment.all.group_by(&:name) unless environment
+    node_records.map do |node_record|
+      env = environment || environments[node_record["environment"]].first
+      new(hostname: node_record["certname"], environment: env)
+    end
   end
 
-  def self.all(environment:)
-    all_names(environment: environment).map do |hostname|
-      new(hostname: hostname, environment: environment)
-    end
+  def self.find(hostname)
+    all.find { |n| n.hostname == hostname }
   end
 
   def ==(other)
@@ -21,7 +24,7 @@ def ==(other)
 
   def facts
     @facts ||=
-      PuppetDbClient.facts(certname: hostname, environment: environment)
+      PuppetDbClient.facts(certname: hostname)
   end
 
   def to_param

app/services/puppet_db_client.rb

@@ -1,23 +1,17 @@
 module PuppetDbClient
   module ClassMethods
-    def nodes(environment:)
-      response = client.request(
-        'inventory',
-        [:'=', 'environment', environment],
-        {}
-      )
-      response.data.map { |x| x.dig("certname") }
+    def nodes(environment: nil)
+      query = environment ? [:'=', 'environment', environment] : nil
+      response = client.request('inventory', query, {})
+      response.data
     rescue
       []
     end
 
-    def facts(certname:, environment:)
+    def facts(certname:)
       response = client.request(
         'facts',
-        [:and,
-          [:'=', 'certname', certname],
-          [:'=', 'environment', environment]
-        ],
+        [:'=', 'certname', certname],
         {}
       )
 

app/views/environments/_select_environment.html.erb

@@ -1,10 +1,12 @@
 <%= form_tag "" do |form| %>
-  <div class="form-group">
+  <div class="form-group" data-controller="slim-select">
     <%= label_tag :environment, "Select environment" %>
-    <select name="environment" data-controller="slim-select select-navigation" data-action="change->select-navigation#navigate">
+    <select name="environment" data-controller="select-navigation" data-action="change->select-navigation#navigate" data-slim-select-target="dropdown">
       <option value="" <%= "selected" if @environment.nil? %> data-url="<%= environments_path %>"></option>
       <% @environments.each do |environment| %>
-        <option data-url="<%= environment_nodes_path(environment) %>" <%= "selected" if environment == @environment %>><%= environment.name %></option>
+        <option data-url="<%= environment_nodes_path(environment) %>" <%= "selected" if environment == @environment %>>
+          <%= environment.name %><%= " (unused)" unless environment.in_use? %>
+        </option>
       <% end %>
     </select>
   </div>