Add diff view to lookup results #301 #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just like with regular value display from a single file this now checks if a node is from a different environment than the selected one. If it is, the same tabbed view with a diff is presented, showing the lookup result in the selected environment and the diff to the lookup in the original environment.
|
before merging, will be tested by @tuxmea |
|
Works as planned. |
rwaffen
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the issue (#301) and the original discussion I am still not sure, I got it correctly. But I started implementing what I remembered from our discussion of the issue.
When you select a node from a different environment, we already have a diff view for values that are different in the same file from the original environment:
I now added the exact same thing to lookup results. So if I do the lookup in the example above I now get:
Please have a look and let me know if this is what you had in mind.