Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

743 fok multiple issues #735

Merged
merged 2 commits into from
Feb 12, 2024
Merged

743 fok multiple issues #735

merged 2 commits into from
Feb 12, 2024

Conversation

mzaja
Copy link
Contributor

@mzaja mzaja commented Feb 9, 2024

Resolves two issues regarding fill or kill order simulation:

  1. min_fill_size equals requested size when not provided.
  2. Unmatched amount is registered as cancelled, not lapsed.

@mzaja mzaja mentioned this pull request Feb 9, 2024
Closed
4 tasks
@liampauling liampauling changed the base branch from master to release/2.5.8 February 12, 2024 09:44
@liampauling liampauling merged commit 3a8c37e into betcode-org:release/2.5.8 Feb 12, 2024
6 checks passed
@mzaja mzaja deleted the 743-fok-multiple-issues branch February 15, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liampauling liampauling liampauling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzaja @liampauling