{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":790243105,"defaultBranch":"main","name":"pydantic-settings","ownerLogin":"bettermarks","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-04-22T14:23:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/7432395?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1713943401.0","currentOid":""},"activityList":{"items":[{"before":"7505ab1dd696971e07edbd96d07e1c711fb790fa","after":null,"ref":"refs/heads/fix/deeply_nested_env_conflicts_with_non_dict_model_item","pushedAt":"2024-04-24T07:23:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"}},{"before":"2d2f94f51f6f10d61334f0dbe257fc9664b75af3","after":"b4fe4556e2ad383d06cf64c7f2b0ea58f77f5013","ref":"refs/heads/main","pushedAt":"2024-04-24T07:23:16.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: a second level of environment nesting expected a dict (#3)\n\nWhen there was a second/deeper level of environment variable nesting\r\nanother part of the code raised an exception.","shortMessageHtmlLink":"fix: a second level of environment nesting expected a dict (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2260565607\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bettermarks/pydantic-settings/issues/3\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bettermarks/pydantic-settings/pull/3/hovercard\" href=\"https://github.com/bettermarks/pydantic-settings/pull/3\">#3</a>)"}},{"before":"6ceb083dcb8b68fe896dbfb055f40776698476f3","after":"2d2f94f51f6f10d61334f0dbe257fc9664b75af3","ref":"refs/heads/main","pushedAt":"2024-04-24T07:22:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf (#276)","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2258271572\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pydantic/pydantic-settings/issues/276\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pydantic/pydantic-settings/pull/276/hovercard\" href=\"https://github.com/pydantic/pydantic-settings/pull/276\">pydanti…</a>"}},{"before":null,"after":"7505ab1dd696971e07edbd96d07e1c711fb790fa","ref":"refs/heads/fix/deeply_nested_env_conflicts_with_non_dict_model_item","pushedAt":"2024-04-24T07:20:19.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: a second level of environment nesting expected a dict\n\nWhen there was a second/deeper level of environment variable nesting\nanother part of the code raised an exception.","shortMessageHtmlLink":"fix: a second level of environment nesting expected a dict"}},{"before":"1be0fdac2da806a94c9b35c21cc4e31f75a8b2c4","after":"6ceb083dcb8b68fe896dbfb055f40776698476f3","ref":"refs/heads/main","pushedAt":"2024-04-23T11:52:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf (#2)\n\nIf a model defines a leaf as e.g. a string and the user or system sets\r\nan environment var with an additional `env_nested_delimiter + suffix`,\r\n`explode_env_vars` was treating the string as a `dict` (trying to add an\r\nitem to it).\r\n\r\nThis fix checks if the target is indeed a `dict`.\r\n\r\nIn that regard, the whole `explode_env_vars` seems a bit wasteful, in\r\nterms of possible throwing away already computed values, if a deeper\r\nenvironment variable is processed earlier (which is possible, since the\r\niteration order of `os.environ` seems unpredictable).\r\n\r\nresolves #275","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2257154665\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bettermarks/pydantic-settings/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bettermarks/pydantic-settings/pull/2/hovercard\" href=\"https://github.com/bettermarks/pydantic-settings/pull/2\">#2</a>)"}},{"before":"2258703a70a3bb5d9f8880729825680504366d19","after":"1be0fdac2da806a94c9b35c21cc4e31f75a8b2c4","ref":"refs/heads/main","pushedAt":"2024-04-23T11:49:33.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"Merge branch 'pydantic:main' into main","shortMessageHtmlLink":"Merge branch 'pydantic:main' into main"}},{"before":"418b3278edb4acd48578ac342d79641fead47045","after":null,"ref":"refs/heads/fix/superfluous_deep_env_conflicts_with_non_dict_model_leaf","pushedAt":"2024-04-23T09:41:21.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"}},{"before":"a7b0978069fdad9fbd21eab6f440054fa0cf3e12","after":"2258703a70a3bb5d9f8880729825680504366d19","ref":"refs/heads/main","pushedAt":"2024-04-23T08:28:40.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf (#2)\n\nIf a model defines a leaf as e.g. a string and the user or system sets\r\nan environment var with an additional `env_nested_delimiter + suffix`,\r\n`explode_env_vars` was treating the string as a `dict` (trying to add an\r\nitem to it).\r\n\r\nThis fix checks if the target is indeed a `dict`.\r\n\r\nIn that regard, the whole `explode_env_vars` seems a bit wasteful, in\r\nterms of possible throwing away already computed values, if a deeper\r\nenvironment variable is processed earlier (which is possible, since the\r\niteration order of `os.environ` seems unpredictable).\r\n\r\nresolves #275","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2257154665\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bettermarks/pydantic-settings/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bettermarks/pydantic-settings/pull/2/hovercard\" href=\"https://github.com/bettermarks/pydantic-settings/pull/2\">#2</a>)"}},{"before":"8928c0b0d47975738c694f79eae1ef096b92b718","after":"418b3278edb4acd48578ac342d79641fead47045","ref":"refs/heads/fix/superfluous_deep_env_conflicts_with_non_dict_model_leaf","pushedAt":"2024-04-23T08:26:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf\n\nIf a model defines a leaf as e.g. a string and the user or system sets\nan environment var with an additional `env_nested_delimiter + suffix`,\n`explode_env_vars` was treating the string as a `dict` (trying to add an\nitem to it).\n\nThis fix checks if the target is indeed a `dict`.\n\nIn that regard, the whole `explode_env_vars` seems a bit wasteful, in\nterms of possible throwing away already computed values, if a deeper\nenvironment variable is processed earlier (which is possible, since the\niteration order of `os.environ` seems unpredictable).\n\nresolves #275","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf"}},{"before":"dbb63a15cd8a5ffb16e3cce33d7389c3f84f1c66","after":"a7b0978069fdad9fbd21eab6f440054fa0cf3e12","ref":"refs/heads/main","pushedAt":"2024-04-22T18:00:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"Update dependancies (#274)","shortMessageHtmlLink":"Update dependancies (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2255279925\" data-permission-text=\"Title is private\" data-url=\"https://github.com/pydantic/pydantic-settings/issues/274\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/pydantic/pydantic-settings/pull/274/hovercard\" href=\"https://github.com/pydantic/pydantic-settings/pull/274\">pydantic#274</a>)"}},{"before":"62c8f8bcdf5b68248f8db6e769374f6acffeda84","after":"8928c0b0d47975738c694f79eae1ef096b92b718","ref":"refs/heads/fix/superfluous_deep_env_conflicts_with_non_dict_model_leaf","pushedAt":"2024-04-22T17:59:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf\n\nIf a model defines a leaf as e.g. a string and the user or system sets an\nenvironment var with an additional `env_nested_delimiter + suffix`,\n`explode_env_vars` was treating the string as a `dict` by adding an item to it.\n\nThis fix checks if the target is indeed a `dict`.\n\nIn that regard, the whole `explode_env_vars` seems a bit wasteful, in\nterms of possible throwing away already computed values, if a deeper\nenvironment variable is processed earlier (which is possible, since the\niteration order of `os.environ` seems unpredictable).","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf"}},{"before":"a7b0978069fdad9fbd21eab6f440054fa0cf3e12","after":"dbb63a15cd8a5ffb16e3cce33d7389c3f84f1c66","ref":"refs/heads/main","pushedAt":"2024-04-22T17:51:07.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"Merge pull request #1 from bettermarks/fix/superfluous_deep_env_conflicts_with_non_dict_model_leaf\n\nfix: superfluous deep env conflicts with non-dict model leaf","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2257134845\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bettermarks/pydantic-settings/issues/1\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bettermarks/pydantic-settings/pull/1/hovercard\" href=\"https://github.com/bettermarks/pydantic-settings/pull/1\">#1</a> from bettermarks/fix/superfluous_deep_env_confl…"}},{"before":null,"after":"62c8f8bcdf5b68248f8db6e769374f6acffeda84","ref":"refs/heads/fix/superfluous_deep_env_conflicts_with_non_dict_model_leaf","pushedAt":"2024-04-22T17:49:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"diefans","name":"Oliver Berger","path":"/diefans","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/513316?s=80&v=4"},"commit":{"message":"fix: superfluous deep env conflicts with non-dict model leaf\n\nIf a model defines a leaf as e.g. a string and the user or system sets an\nenvironment var with an additional `env_nested_delimiter\n+ suffix`, `explode_env_vars` was treating the string as a `dict` by\n  adding an item to it.\n\nThis fix checks if the target is indeed a `dict`.\n\nIn that regard, the whole `explode_env_vars` seems a bit wasteful, in\nterms of possible throwing away already computed values, if a deeper\nenvironment variable is processed earlier (which is possible, since the\niteration order of `os.environ` seems unpredictable).","shortMessageHtmlLink":"fix: superfluous deep env conflicts with non-dict model leaf"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEONTgpQA","startCursor":null,"endCursor":null}},"title":"Activity · bettermarks/pydantic-settings"}