Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration guide corrections #1540

Closed
ilyvion opened this issue Jul 6, 2024 · 3 comments · Fixed by #1550
Closed

Migration guide corrections #1540

ilyvion opened this issue Jul 6, 2024 · 3 comments · Fixed by #1550
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written
Milestone

Comments

@ilyvion
Copy link

ilyvion commented Jul 6, 2024

The signature of the function you need to pass to App::set_runner has changed and this isn't mentioned at all in the migration guide.

Also, the section "Separate states from core ECS" states

Projects that use bevy_app directly and use states will need to add the bevy_state feature.

but bevy_app has no such feature. I think maybe you meant "that use bevy directly?" (It has a feature with that name)

@BD103
Copy link
Member

BD103 commented Jul 6, 2024

Thanks for the report! I think the signature likely changed in the AppExit PR, but I'll need to go through the blame to confirm.

As for the second bit, I actually just fixed it yesterday in #1539! :)

@alice-i-cecile alice-i-cecile added A-Migration Guides C-Correction A typo, problem or factual issue in what we've written labels Jul 7, 2024
@alice-i-cecile alice-i-cecile added this to the Release v0.14 milestone Jul 7, 2024
@alice-i-cecile
Copy link
Member

App::set_runner changes will be due to bevyengine/bevy#9202

@BD103
Copy link
Member

BD103 commented Jul 12, 2024

App::set_runner changes will be due to bevyengine/bevy#9202

It also appears that bevyengine/bevy#13022 contributed to the breaking change as well. I'm working on a PR for this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Migration Guides C-Correction A typo, problem or factual issue in what we've written
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants