From 0dfb6cf89b27b8ea283c55097e469e449b182416 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois?= <mockersf@gmail.com>
Date: Thu, 2 Nov 2023 22:54:41 +0100
Subject: [PATCH] don't Implement `Display` for `Val` (#10345)

# Objective

- Revert #10296

## Solution

- Avoid implementing `Display` without a justification
- `Display` implementation is a guarantee without a direct use, takes
additional time to compile and require work to maintain
- `Debug`, `Reflect` or `Serialize` should cover all needs
---
 crates/bevy_ui/src/geometry.rs | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/crates/bevy_ui/src/geometry.rs b/crates/bevy_ui/src/geometry.rs
index 799e827257a1d..9462ef4e770d5 100644
--- a/crates/bevy_ui/src/geometry.rs
+++ b/crates/bevy_ui/src/geometry.rs
@@ -4,7 +4,6 @@ use bevy_reflect::ReflectDeserialize;
 use bevy_reflect::ReflectSerialize;
 use serde::Deserialize;
 use serde::Serialize;
-use std::fmt::Display;
 use std::ops::Neg;
 use std::ops::{Div, DivAssign, Mul, MulAssign};
 use thiserror::Error;
@@ -156,22 +155,6 @@ impl DivAssign<f32> for Val {
     }
 }
 
-impl Display for Val {
-    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
-        let (value, suffix) = match self {
-            Val::Auto => return write!(f, "auto"),
-            Val::Px(value) => (value, "px"),
-            Val::Percent(value) => (value, "%"),
-            Val::Vw(value) => (value, "vw"),
-            Val::Vh(value) => (value, "vh"),
-            Val::VMin(value) => (value, "vmin"),
-            Val::VMax(value) => (value, "vmax"),
-        };
-        value.fmt(f)?;
-        write!(f, "{suffix}")
-    }
-}
-
 impl Neg for Val {
     type Output = Val;