Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning log about time when starting an example #6355

Closed
mockersf opened this issue Oct 24, 2022 · 4 comments
Closed

warning log about time when starting an example #6355

mockersf opened this issue Oct 24, 2022 · 4 comments
Labels
A-Time Involves time keeping and reporting C-Bug An unexpected or incorrect behavior
Milestone

Comments

@mockersf
Copy link
Member

Bevy version

since f7d3fbc (#6159)

What you did

Run an example

What went wrong

There is a log:

WARN bevy_time: time_system did not receive the time from the render world! Calculations depending on the time may be incorrect.
@mockersf mockersf added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Oct 24, 2022
@mockersf mockersf changed the title warning log when starting an example about time warning log about time when starting an example Oct 24, 2022
@mockersf mockersf added A-Time Involves time keeping and reporting and removed S-Needs-Triage This issue needs to be labelled labels Oct 24, 2022
@mockersf mockersf added this to the Bevy 0.9 milestone Oct 24, 2022
@hymm
Copy link
Contributor

hymm commented Oct 24, 2022

I missed this in review. It's due to has_received_time being removed in #6159.

@Lucidus115 did you want to fix this? If not I can.

@ShinySapphic
Copy link
Contributor

I missed this in review. It's due to has_received_time being removed in #6159.

@Lucidus115 did you want to fix this? If not I can.

I'll quickly fix it. I didn't realize what it did exactly and probably should have left it alone.

@hymm
Copy link
Contributor

hymm commented Oct 24, 2022

I didn't realize what it did exactly

The first time that the system runs it won't have a time from the render world yet. So the bit suppresses the warning until it gets a time. I purposely didn't write it to only skip the first frame, since when we actually get pipelined rendering it'll be the first 2 frames without a time.

@ShinySapphic
Copy link
Contributor

The first time that the system runs it won't have a time from the render world yet.

That makes sense. Also I made the silly mistake of not reading the docs for the Local struct properly and didn't realize it held the value for every time the system runs.

@bors bors bot closed this as completed in 6aa2dce Oct 24, 2022
james7132 pushed a commit to james7132/bevy that referenced this issue Oct 28, 2022
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this issue Dec 17, 2022
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
ItsDoot pushed a commit to ItsDoot/bevy that referenced this issue Feb 1, 2023
# Objective

- Fixes bevyengine#6355 

## Solution

- Add the removed local bool from bevyengine#6159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Time Involves time keeping and reporting C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants