-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mesh insert indices #11745
Mesh insert indices #11745
Conversation
Added `Mesh::with_removed_indices` and updated `Mesh::set_indices` as well as `Mesh::with_indices`.
I'm not sure about the naming of |
I personally prefer But that's just personal preference, the current state of the PR LGTM |
Looks like this needs a bit of clean up: CI errors look real. |
new users of the renamed apis have been added to main, they need to be updated too |
Should be good to go now |
Objective
Mesh::set_indices
intoMesh::insert_indices
#11740Solution
Mesh::set_indices
intoMesh::insert_indices
and added related methods for completeness.Changelog
Mesh::set_indices(indices: Option<Indices>)
withMesh::insert_indices(indices: Indices)
Mesh::with_indices(indices: Option<Indices>)
withMesh::with_inserted_indices(indices: Indices)
andMesh::with_removed_indices()
mirroring the API for inserting / removing attributes.Migration Guide
Mesh::insert_indices
orMesh::with_inserted_indices
instead ofMesh::set_indices
/Mesh::with_indices
.None
toMesh::set_indices
orMesh::with_indices
you should useMesh::remove_indices
orMesh::with_removed_indices
instead.