Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Re-add ECS benchmark suite #4332

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - Re-add ECS benchmark suite #4332

wants to merge 1 commit into from

Conversation

alice-i-cecile
Copy link
Member

Objective

  • Benchmarks are good.
  • Licensing situation appears to be cleared up.

Solution

@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times labels Mar 25, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 25, 2022
@notverymoe notverymoe mentioned this pull request Mar 26, 2022
Closed
@mockersf
Copy link
Member

bors r+

bors bot pushed a commit that referenced this pull request Mar 29, 2022
@alice-i-cecile @DJMcNab
Re-add ECS benchmark suite (#4332)
1b63d94 
# Objective

- Benchmarks are good.
- Licensing situation appears to be [cleared up](#4225 (comment)).

## Solution

- Add the benchmark suite back in
- Suggested PR title: "Revert "Revert "Add cart's fork of ecs_bench_suite (#4225)" (#4252)"


Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
@bors
Copy link
Contributor

bors bot commented Mar 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Re-add ECS benchmark suite [Merged by Bors] - Re-add ECS benchmark suite Mar 29, 2022
@bors bors bot closed this Mar 29, 2022
aevyrie pushed a commit to aevyrie/bevy that referenced this pull request Jun 7, 2022
@alice-i-cecile @DJMcNab @aevyrie
Re-add ECS benchmark suite (bevyengine#4332)
b4ea4d5 
# Objective

- Benchmarks are good.
- Licensing situation appears to be [cleared up](bevyengine#4225 (comment)).

## Solution

- Add the benchmark suite back in
- Suggested PR title: "Revert "Revert "Add cart's fork of ecs_bench_suite (bevyengine#4225)" (bevyengine#4252)"


Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
@alice-i-cecile @DJMcNab @ItsDoot
Re-add ECS benchmark suite (bevyengine#4332)
32bdec2 
# Objective

- Benchmarks are good.
- Licensing situation appears to be [cleared up](bevyengine#4225 (comment)).

## Solution

- Add the benchmark suite back in
- Suggested PR title: "Revert "Revert "Add cart's fork of ecs_bench_suite (bevyengine#4225)" (bevyengine#4252)"


Co-authored-by: Daniel McNab <36049421+DJMcNab@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@james7132 james7132 james7132 approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Performance A change motivated by improving speed, memory usage or compile times S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alice-i-cecile @mockersf @james7132 @DJMcNab