[Bug|Magento]: After activating pro: Unable to find the wrapper "phar"

[kayintveen]

Operating system version

macOS Sonoma 14.2.1 (23C71)

System architecture

ARM64 (M1, M2, etc)

Herd Version

1.4.0

PHP Version

PHP 8.1.26 (cli) (built: Dec 21 2023 08:51:01) (NTS)

Bug description

When I activated Pro, my CLI stopped working.

Warning: stream_resolve_include_path(): Unable to find the wrapper "phar" - did you forget to enable it when you configured PHP? in phar:///Applications/Herd.app/Contents/Resources/valet/dump.phar/vendor/composer/ClassLoader.php on line 557

Tried restarting, rebooting, herd restart and switching between PHP 8.1 (which I need for this project) and 8.2

Steps to reproduce

actived pro on a clean install

Relevant log output

No response

[mpociot]

Are you sure that php on the CLI points to the correct binary?
Can you share your which php output?

[kayintveen]

Yes

❯ which php
/Users/kayintveen/Library/Application Support/Herd/bin//php

[mpociot]

What do you get when you run

php -i | grep "Registered PHP Streams"

It should give you: "Registered PHP Streams => https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip"

[sschlein]

You should be back to a running system if you open the Dumps window and stop dump interception.

We're investigating this at the moment but it could be Magento related.

[kayintveen]

What do you get when you run

php -i | grep "Registered PHP Streams"

It should give you: "Registered PHP Streams => https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip"

Phar is in there.
Registered PHP Streams => https, ftps, compress.zlib, compress.bzip2, php, file, glob, data, http, ftp, phar, zip

You should be back to a running system if you open the Dumps window and stop dump interception.

We're investigating this at the moment but it could be Magento related.

i was not sure how to do this. I expected this to be in the dumps pane to enable / disable it. but its in the dumps screen itself I can stop listening. and this fixed it for now.

[mpociot]

This seems to be related to Magento unregistering the phar stream...

See: magento/magento2#21973

I suppose you run into this when running Magento related commands via the CLI?

[kayintveen]

This seems to be related to Magento unregistering the phar stream...

See: magento/magento2#21973

I suppose you run into this when running Magento related commands via the CLI?

In this case I was indeed running bin/magento setup:upgrade

but before herd pro i had no issues (either with brew version of PHP or non-pro 1.4.0 herd.)

[mpociot]

Yeah, Herd Pro loads a phar file to inject the dump and dd methods, which is why you ran into it - and which is why disabling the dump interception fixes it.

[kayintveen]

For now i keep it disabled for magento hopefully a minor version upgrade will fix it later. Thanks!

[mpociot]

@kayintveen some time ago I sent you a potential fix for this. Did you find the time to try this?

[kayintveen]

To be honest. its working now but i did not change the thing you did. not sure what did fix it though ;(

[barryvdh]

Same issue with the latest version. How can I disable the dump interception?

[barryvdh]

Nevermind, find the button. But still breaks Magento

[mpociot]

@barryvdh I wasn't able to verify the fix that I sent to @kayintveen
Could you try the following:

Add

if (!in_array('phar', \stream_get_wrappers())) {
    \stream_wrapper_restore('phar');
}

To this file: /Applications/Herd.app/Contents/Resources/valet/dump-loader.php

Right before the include.
It seems like Magento is still unregistering the phar stream

[barryvdh]

Not sure how to best test that, my Mac doesn't seem to like me changing that file.

[kayintveen]

Some how I fixed it. But I don't remember how. would love to have this working out of the box. i mainly had the issue with Magento as well.
Let me check with my team as more people use Magento with Herd now.

[barryvdh]

If you disable the interception, there is no issue:

Does intercepting work for you now?

I think the fix should work, it's also mentioned here; magento/magento2#21973 (comment)

[mpociot]

Yeah, when the interception is disabled we're not loading a PHAR file.

I'll just apply the fix in the next update, as I also doesn't see any reasons why this should break anything