No issue: Add a unit test for get measure display info #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IgorNadj
approved these changes
Jul 4, 2022
| @@ -185,6 +185,25 @@ describe('measures', () => { | |||
| const display3 = getMeasureDisplayInfo({ questionC: 0.5 }, [optionsSpectrum]); | |||
| expect(display3).toHaveProperty('color', 'hsl(50, 100%, 50%)'); | |||
| }); | |||
|
|
|||
| it('Coloured radius choose a colour from a spectrum, and pick radius from radius', () => { | |||
There was a problem hiding this comment.
This test title is a little hard to understand. I suggest we call it something shorter like 'should support coloured radius' and if you want the longer description pop in in a comment inside the test case
| @@ -104,27 +103,6 @@ const getNullValueMapping = type => { | |||
| return baseMapping; | |||
| }; | |||
|
|
|||
| function getFormattedValue(value, type, valueInfo, scaleType, valueType, submissionDate) { | |||
There was a problem hiding this comment.
I love when code gets deleted, nice one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #:
Add a unit test to describe how dynamic coloured radius works.