WAITP-1145 create commands for reloading on dev #4420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-pollard
approved these changes
Apr 4, 2023
tcaiger
reviewed
Apr 4, 2023
packages/web-frontend/package.json
Outdated
| "test": "node scripts/test.js --env=jsdom" | ||
| "test": "node scripts/test.js --env=jsdom", | ||
| "start-ui-components": "yarn workspace @tupaia/ui-components start-dev", | ||
| "start-frontend": "npm-run-all -c -l -p start-components start-dev" |
There was a problem hiding this comment.
Suggested change
| "start-frontend": "npm-run-all -c -l -p start-components start-dev" | |
| "start-frontend": "npm-run-all -c -l -p start-ui-components start-dev" |
I think this should be start-ui-components right?
tcaiger
requested changes
Apr 4, 2023
There was a problem hiding this comment.
Amazing work getting the watch to work in ui-components. I tried to test it locally and the ui-components dev build seems to work well but I'm getting an error when I run the yarn build in ui-components and also for some reason the my server scripts are throwing errors too when I try to start them. Do you get these errors locally too? I think that is why the codeship build is failing too.
IgorNadj
suggested changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue WAITP-1145
Changes:
ui-componentsstart-devthat watches changesweb-frontendstart-serversthat just starts the servers, so that when running the frontend you can run the servers separately if you wish.web-frontendstart-ui-componentsthat runs thestart-devcommand in theui-componentspackageweb-frontendstart-frontendthat runs and watches theweb-frontendandui-componentspackages. This means when you update anything inui-components/src, it will trigger a reload ofweb-frontendso you don't have to rebuild anything manually.