Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-issue: Fix minor button spacing jank #5419

Merged
merged 2 commits into from
Feb 14, 2024
Merged

no-issue: Fix minor button spacing jank #5419

merged 2 commits into from
Feb 14, 2024

Conversation

jaskfla
Copy link
Contributor

@jaskfla jaskfla commented Feb 13, 2024

Changes

  • In ProjectAccessForm, when the form state validity changes, the button spacing would jump around. This PR fixes that.
  • Also some refactors, copied over from WAITP-1468: Request Country Access (superseded) #5268: use CSS logical properties where appropriate and remove a redundant <div>

Screenshots

These screenshots show the old behaviour. Notice how the buttons are differently spaced in each screenshot.

Screenshot 2024-02-13T145112

Screenshot 2024-02-13T145121

@jaskfla jaskfla changed the title no-issue: Fix minor button spacing tank no-issue: Fix minor button spacing jank Feb 13, 2024
@jaskfla jaskfla merged commit d4b555e into dev Feb 14, 2024
42 checks passed
@jaskfla jaskfla deleted the fix-ui-jank branch February 14, 2024 18:54
@jaskfla jaskfla mentioned this pull request Feb 14, 2024
@avaek avaek mentioned this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants